Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore(test): remove deprecated algorithm #206

Merged
merged 1 commit into from
Nov 18, 2022
Merged

Conversation

angela-tran
Copy link
Member

@angela-tran angela-tran commented Nov 18, 2022

Our pytest check has been failing (e.g. the one for #205)

@thekaveman found python/cpython#91257, which says:

The hashlib.algorithms_available set includes algorithms like ripemd160 and whirlpool, those algorithms are not usable unless openssl legacy provider is loaded. Since it's not loaded, and the hashlib module won't load it, any attempt to use them fails.

We'll remove whirlpool from our test cases.

@angela-tran angela-tran self-assigned this Nov 18, 2022
@angela-tran angela-tran requested a review from a team as a code owner November 18, 2022 21:43
Copy link
Member

@thekaveman thekaveman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See python/cpython#91257

We aren't using this algorithm in production and so OK to remove from the tests.

@angela-tran angela-tran merged commit 5135cfc into dev Nov 18, 2022
@angela-tran angela-tran deleted the chore/fix-pytest-check branch November 18, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants