Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

start addressing dependabot-flagged issues and add missing image build workflow #1824

Merged
merged 5 commits into from
Sep 21, 2022

Conversation

atvaccaro
Copy link
Contributor

@atvaccaro atvaccaro commented Sep 21, 2022

This should close a bunch of the dependabot PRs. It also aligns our various image building workflow names and updates poetry as needed.

I tested the aggregator checker changes.

[2022-09-21 17:08:15,472] {pod_launcher.py:149} INFO - https://data.trilliumtransit.com/gtfs/tracy-ca-us/tracy-ca-us.zip
[2022-09-21 17:08:15,473] {pod_launcher.py:149} INFO - saving results to gs://gtfs-data-test/feed_aggregator_checks/dt=2022-09-21/checks.jsonl
[2022-09-21 17:08:15,628] {pod_launcher.py:149} INFO - Results saved to gs://gtfs-data-test/feed_aggregator_checks/dt=2022-09-21/checks.jsonl
Fetching individual feed URLs: 100%|██████████| 177/177 [00:39<00:00,  4.45it/s]
[2022-09-21 17:08:17,850] {pod_launcher.py:198} INFO - Event: check-aggregators.26438c56ca7545919ff3363b889f7f26 had an event of type Succeeded
[2022-09-21 17:08:17,850] {pod_launcher.py:311} INFO - Event with job id check-aggregators.26438c56ca7545919ff3363b889f7f26 Succeeded
[2022-09-21 17:08:17,950] {pod_launcher.py:198} INFO - Event: check-aggregators.26438c56ca7545919ff3363b889f7f26 had an event of type Succeeded
[2022-09-21 17:08:17,951] {pod_launcher.py:311} INFO - Event with job id check-aggregators.26438c56ca7545919ff3363b889f7f26 Succeeded
[2022-09-21 17:08:18,110] {taskinstance.py:1212} INFO - Marking task as SUCCESS. dag_id=check_feed_aggregators, task_id=check_aggregators, execution_date=20220921T000000, start_date=20220921T162940, end_date=20220921T170818

@atvaccaro atvaccaro self-assigned this Sep 21, 2022
@atvaccaro atvaccaro changed the title start addressing dependabot-flagged issues start addressing dependabot-flagged issues and add missing image build workflow Sep 21, 2022
@atvaccaro atvaccaro marked this pull request as ready for review September 21, 2022 17:09
Copy link
Contributor

@lauriemerrell lauriemerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • can you list the specific dependabot issues/PRs that you think this will close or that you are working from? just to understand which specific dependency issues we intend to be fixing here.
  • why do we need to rename the github workflows? just consistency or is there a functional reason?
  • will dependabot close its PRs on its own?

@atvaccaro
Copy link
Contributor Author

  • can you list the specific dependabot issues/PRs that you think this will close or that you are working from? just to understand which specific dependency issues we intend to be fixing here.

Yep!
#1809
#1801
#1800
#1799
#1798
#1797
#1796

  • why do we need to rename the github workflows? just consistency or is there a functional reason?

Just for consistency, since I'm adding a new one.

  • will dependabot close its PRs on its own?

I believe so yes.

Copy link
Contributor

@lauriemerrell lauriemerrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@atvaccaro
Copy link
Contributor Author

ah yeah good catch; that's the temporary workaround for python-poetry/poetry-plugin-export#118; I need to update it there too

  • can you just add a note to the PR description nothing that we are also updating the poetry version -- I was confused about some of the diffs here like why the Dockerfiles are involved

done

@atvaccaro atvaccaro merged commit 0358519 into main Sep 21, 2022
@atvaccaro atvaccaro deleted the update-deps branch September 21, 2022 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants