-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
start addressing dependabot-flagged issues and add missing image build workflow #1824
Conversation
757a504
to
1228708
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- can you list the specific dependabot issues/PRs that you think this will close or that you are working from? just to understand which specific dependency issues we intend to be fixing here.
- why do we need to rename the github workflows? just consistency or is there a functional reason?
- will dependabot close its PRs on its own?
Yep!
Just for consistency, since I'm adding a new one.
I believe so yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Re: https://github.com/cal-itp/data-infra/pull/1809/files -- why does
warehouse/requirements.txt
even exist at all? (that file is not updated in this PR) - can you just add a note to the PR description nothing that we are also updating the poetry version -- I was confused about some of the diffs here like why the Dockerfiles are involved
ah yeah good catch; that's the temporary workaround for python-poetry/poetry-plugin-export#118; I need to update it there too
done |
This should close a bunch of the dependabot PRs. It also aligns our various image building workflow names and updates poetry as needed.
I tested the aggregator checker changes.