Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempts to build wheels across more architectures #120

Merged
merged 6 commits into from
Jan 13, 2023
Merged

Attempts to build wheels across more architectures #120

merged 6 commits into from
Jan 13, 2023

Conversation

colindean
Copy link
Contributor

@colindean
Copy link
Contributor Author

N.b. this change is an (educated) shot in the dark.

@colindean
Copy link
Contributor Author

It looks like the wheel building succeeded and what failed is that I don't have a token setup to test upload to pypi.

@jordemort
Copy link
Contributor

I'll try and figure out how to run it with the token, I want to see how it looks on TestPyPI with the additional architectures before I merge.

This should make the step name more apparent when the matrix expands
@colindean
Copy link
Contributor Author

Any change you'd take a look at this in the next few days?

@jordemort jordemort mentioned this pull request Jan 13, 2023
@jordemort jordemort added the bump:patch Bump patch version (0.0.x) label Jan 13, 2023
@jordemort
Copy link
Contributor

Thanks for the contribution!

I made a couple of tweaks:

  • Actions was whining that ${{runner.os}} was a syntax error, so I just removed it
  • Instead of building x86_64 for all the macOS versions and also universal2 for > 3.7, I switched > 3.7 to be universal2-only

Waiting for one more cycle of CI and then I'll merge. I've tagged this PR as a patch version bump so fresh wheels should be available on PyPI shortly thereafter.

@jordemort jordemort merged commit 15a0f5e into caketop:main Jan 13, 2023
@jordemort
Copy link
Contributor

🚀 [bumpr] Bumped! New version:v0.1.2 Changes:v0.1.1...v0.1.2

@jordemort
Copy link
Contributor

https://github.com/caketop/python-starlark-go/releases/tag/v0.1.2 is now available here and on PyPI.

It looks like we inadvertently dropped i686 support here; I'm going to wait and see if anyone complains about that before I worry about putting it back.

I put a release announcement on my blog: https://jordemort.dev/blog/python-starlark-go-0.1.2/

@colindean colindean deleted the patch-1 branch January 15, 2023 06:06
@colindean
Copy link
Contributor Author

Thank you for merging and for the recognition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump:patch Bump patch version (0.0.x)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import module on M1 Mac
2 participants