Add rector rules to update migration base classes (#304)

Part of the work to separate migrations from phinx

Makefile

@@ -3,7 +3,8 @@
 DEV_DEPENDENCIES = cakephp/cakephp:5.x-dev \
   cakephp/cakephp-codesniffer:^5.0 \
   mikey179/vfsstream:^1.6.8 \
-  phpunit/phpunit:^10.5.38
+  phpunit/phpunit:^10.5.38 \
+  cakephp/migrations:^4.5.0
 
 install-dev:
 	composer require --dev $(DEV_DEPENDENCIES)

config/rector/migrations45.php

@@ -0,0 +1,9 @@
+<?php
+declare(strict_types=1);
+
+use Cake\Upgrade\Rector\Set\CakePHPSetList;
+use Rector\Config\RectorConfig;
+
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->sets([CakePHPSetList::MIGRATIONS_45]);
+};

config/rector/sets/migrations45.php

@@ -0,0 +1,15 @@
+<?php
+declare(strict_types=1);
+
+use Rector\Config\RectorConfig;
+use Rector\Renaming\Rector\Name\RenameClassRector;
+
+/**
+ * @see https://github.com/cakephp/migrations/releases/4.5.0/
+ */
+return static function (RectorConfig $rectorConfig): void {
+    $rectorConfig->ruleWithConfiguration(RenameClassRector::class, [
+        'Migrations\AbstractMigration' => 'Migrations\BaseMigration',
+        'Migrations\AbstractSeed' => 'Migrations\BaseSeed',
+    ]);
+};

src/Rector/Set/CakePHPSetList.php

@@ -85,6 +85,11 @@ final class CakePHPSetList
      */
     public const CHRONOS_3 = __DIR__ . '/../../../config/rector/sets/chronos3.php';
 
+    /**
+     * @var string
+     */
+    public const MIGRATIONS_45 = __DIR__ . '/../../../config/rector/sets/migrations45.php';
+
     /**
      * @var string
      */

tests/TestCase/Command/RectorCommandTest.php

@@ -105,4 +105,11 @@ public function testApply52()
         $this->exec('upgrade rector --rules cakephp52 ' . TEST_APP);
         $this->assertTestAppUpgraded();
     }
+
+    public function testApplyMigrations45()
+    {
+        $this->setupTestApp(__FUNCTION__);
+        $this->exec('upgrade rector --rules migrations45 ' . TEST_APP);
+        $this->assertTestAppUpgraded();
+    }
 }

tests/TestCase/TestCase.php

@@ -27,6 +27,8 @@ class TestCase extends BaseTestCase
 {
     use ConsoleIntegrationTestTrait;
 
+    public $appPluginsToLoad = [];
+
     /**
      * @var string
      */

tests/test_apps/original/RectorCommand-testApplyMigrations45/src/Migrations45.php

@@ -0,0 +1,13 @@
+<?php
+use Migrations\AbstractMigration;
+use Migrations\AbstractSeed;
+
+class Migrations45 extends AbstractMigration {
+    public function change() {
+    }
+}
+
+class Seed45 extends AbstractSeed {
+    public function run() {
+    }
+}

tests/test_apps/upgraded/RectorCommand-testApplyMigrations45/src/Migrations45.php

@@ -0,0 +1,13 @@
+<?php
+use Migrations\AbstractMigration;
+use Migrations\AbstractSeed;
+
+class Migrations45 extends \Migrations\BaseMigration {
+    public function change() {
+    }
+}
+
+class Seed45 extends \Migrations\BaseSeed {
+    public function run() {
+    }
+}