2.next: more DIC #278
Merged
2.next: more DIC #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LordSimal
force-pushed
the
2.next-more-dic
branch
from
91c585f to
183e7f9
Compare
|
This looks good, and it enables us to remove a lot of awkward workaround code that we had to have before when we were forced to implement the Thanks Kevin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
yea... you read that right.... 😁
This is a direct response to #265 (comment) and the need to set a custom DIC in the authorization handler if the passed down subject doesn't actually implement the
ContainerApplicationInterfaceThis allows users to extract the container logic from the authorization service logic if they for some reason don't want it to have it all in their Application.php