CW-685 Add passphrase restore for xmr/wow #1552
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Getting grayed screen on latest passphrase build after having restored a 14-word wownero seed (+passphrase) and attempting to restore a XMR seed, legacy or otherwise.
…ero-wownero-wallets # Conflicts: # cw_monero/lib/api/wallet.dart # cw_wownero/lib/api/wallet.dart # tool/configure.dart
…-wallets # Conflicts: # cw_monero/lib/api/wallet.dart # cw_wownero/lib/api/wallet.dart
OmarHatem28
previously requested changes
Aug 21, 2024
OmarHatem28
reviewed
Aug 22, 2024
add passphrase to qr code backup export
OmarHatem28
reviewed
Aug 22, 2024
OmarHatem28
reviewed
Aug 22, 2024
MrCyjaneK
changed the title
|
@konstantinullrich polyseed restore with passphrase is not compatible with feather wallet. |
MrCyjaneK
changed the title
MrCyjaneK
force-pushed
the
CW-685-passphrase-support-for-monero-wownero-wallets
branch
from
03f77a5
to
312e285
Compare
|
@MrCyjaneK please update this when possible and see if there is any other issues left from testers |
MrCyjaneK
dismissed
OmarHatem28’s stale review
discussed at standups, should be good (and I want to update the PR with latest main)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number (if Applicable): Fixes #
Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist