Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Embedd the warp binaries and extract the correct binary when the library gets loaded #4

Closed
AdmiringWorm opened this issue May 8, 2019 · 4 comments
Closed

Embedd the warp binaries and extract the correct binary when the library gets loaded #4

AdmiringWorm opened this issue May 8, 2019 · 4 comments
Assignees
@AdmiringWorm
Labels
Feature New non-breaking functionality
Milestone
0.1.0

Comments

@AdmiringWorm
Copy link
Member

This is possible to do by using one of the Fody Weavers, and would allow the addin to not have any external dependencies (Which would be the best as there is currently no installation for Warp, only download and execute(
@AdmiringWorm AdmiringWorm added this to the 0.1.0 milestone May 8, 2019
@AdmiringWorm AdmiringWorm added the Feature New non-breaking functionality label May 8, 2019
@gep13
Copy link
Member

gep13 commented May 8, 2019

I will be curious to see how you implement this!

@AdmiringWorm
Copy link
Member Author

I was testing something of that sort yesterday, and got something.
But want to finish up all the configurations before I commit that code.

I will open it as a PR so you can have a look at it. Although the code for that is simple, I believe it would be best with a second pair of eyes to make sure.

@gep13
Copy link
Member

gep13 commented May 8, 2019

Sure thing! Keep me posted, in case I miss a notification.

@AdmiringWorm AdmiringWorm self-assigned this May 8, 2019
AdmiringWorm added a commit that referenced this issue May 9, 2019
@AdmiringWorm
(GH-4) Added module initializer using ModuleInit..Fody
171809a
AdmiringWorm added a commit that referenced this issue May 9, 2019
@AdmiringWorm
(GH-4) Added ability to save warp file to disk on library load
ccb55ac
AdmiringWorm added a commit that referenced this issue May 9, 2019
@AdmiringWorm
(GH-4) Added module initializer using ModuleInit..Fody
bdc233d
AdmiringWorm added a commit that referenced this issue May 9, 2019
@AdmiringWorm
(GH-4) Added ability to save warp file to disk on library load
93e76e7
@AdmiringWorm AdmiringWorm mentioned this issue May 9, 2019
Closed
4 tasks
AdmiringWorm added a commit that referenced this issue May 10, 2019
@AdmiringWorm
(GH-4) Added a check to see if the file already exist
7decddd 
in such a case, we should not extract the
binary file.
AdmiringWorm added a commit that referenced this issue May 10, 2019
@AdmiringWorm
(GH-4) Updated to set executable bit on unix platforms
6ec1a06
AdmiringWorm added a commit that referenced this issue May 10, 2019
@AdmiringWorm
(GH-4) Added module initializer using ModuleInit..Fody
9c3af8b
AdmiringWorm added a commit that referenced this issue May 10, 2019
@AdmiringWorm
(GH-4) Added ability to save warp file to disk on library load
16e297f
AdmiringWorm added a commit that referenced this issue May 10, 2019
@AdmiringWorm
(GH-4) Added a check to see if the file already exist
af82ce3 
in such a case, we should not extract the
binary file.
AdmiringWorm added a commit that referenced this issue May 10, 2019
@AdmiringWorm
(GH-4) Updated to set executable bit on unix platforms
5327177
AdmiringWorm added a commit that referenced this issue May 10, 2019
@AdmiringWorm
(GH-4) Added module initializer using ModuleInit..Fody
1b1c684
AdmiringWorm added a commit that referenced this issue May 10, 2019
@AdmiringWorm
(GH-4) Added ability to save warp file to disk on library load
0640e7f
AdmiringWorm added a commit that referenced this issue May 10, 2019
@AdmiringWorm
(GH-4) Added a check to see if the file already exist
d463886 
in such a case, we should not extract the
binary file.
AdmiringWorm added a commit that referenced this issue May 10, 2019
@AdmiringWorm
(GH-4) Updated to set executable bit on unix platforms
73f252a
AdmiringWorm added a commit that referenced this issue May 12, 2019
@AdmiringWorm
(GH-4) Added module initializer using ModuleInit..Fody
acf0093
AdmiringWorm added a commit that referenced this issue May 12, 2019
@AdmiringWorm
(GH-4) Added ability to save warp file to disk on library load
9444816
AdmiringWorm added a commit that referenced this issue May 12, 2019
@AdmiringWorm
(GH-4) Added a check to see if the file already exist
f34db8e 
in such a case, we should not extract the
binary file.
AdmiringWorm added a commit that referenced this issue May 12, 2019
@AdmiringWorm
(GH-4) Updated to set executable bit on unix platforms
a26e68e
@AdmiringWorm
Copy link
Member Author

Implemented in fc658a0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AdmiringWorm AdmiringWorm

Labels
Feature New non-breaking functionality
Projects
None yet
Milestone
0.1.0
Development

Successfully merging a pull request may close this issue.

(GH-4) Added ability to load the embedded warp files during addin load cake-contrib/Cake.Warp
2 participants
@gep13 @AdmiringWorm