Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetIterationChanges should return empty collection instead of null #459

Merged
merged 1 commit into from
Nov 26, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -771,12 +771,12 @@ public int GetLatestIterationId()
/// Gets all the pull request changes of the given iteration.
/// </summary>
/// <param name="iterationId">The id of the iteration.</param>
/// <returns>The collection of the iteration changes of the given id. Returns <c>null</c> if pull request is not valid.</returns>
/// <returns>The collection of the iteration changes of the given id. Returns an empty collection if pull request is not valid.</returns>
public IEnumerable<AzureDevOpsPullRequestIterationChange> GetIterationChanges(int iterationId)
{
if (!this.ValidatePullRequest())
{
return null;
return [];
}

using (var gitClient = this.gitClientFactory.CreateGitClient(this.CollectionUrl, this.credentials))
Expand Down