Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Artifact types should be handled case insensitive #430

Closed
christianbumann opened this issue Oct 10, 2023 · 1 comment · Fixed by #431
Closed

Artifact types should be handled case insensitive #430

christianbumann opened this issue Oct 10, 2023 · 1 comment · Fixed by #431
Labels
Bug
Milestone
3.0.1

Comments

@christianbumann
Copy link
Member

christianbumann commented Oct 10, 2023 •
edited by pascalberger
Loading

AzureDevOpsBuild.GetArtifact and AzureDevOpsBuild.LinkArtifact can fail when ToAzureDevOpsArtifactResource tries to parse the artifact type.
Since the value which is coming from Azure DevOps can be lowercase (e.g. in case of Azure DevOps Server), the comparison should be case-insensitive.
@christianbumann christianbumann changed the title ToAzureDevOpsArtifactResource should try-parse case insensitive instead of case sensitive ToAzureDevOpsArtifactResource should try-parse the artifact type case insensitive instead of case sensitive Oct 10, 2023
christianbumann added a commit to christianbumann/Cake.AzureDevOps that referenced this issue Oct 10, 2023
@christianbumann
Fixes cake-contrib#430
918cc56
christianbumann added a commit to christianbumann/Cake.AzureDevOps that referenced this issue Oct 10, 2023
@christianbumann
Fixes cake-contrib#430
4496340
christianbumann added a commit to christianbumann/Cake.AzureDevOps that referenced this issue Oct 10, 2023
@christianbumann
Fixes cake-contrib#430
a3eff18
@christianbumann
Copy link
Member Author

christianbumann commented Oct 10, 2023 •
edited
Loading

@pascalberger feel free to beautify this issue (description, header) or do some corrections on the test.

@pascalberger pascalberger mentioned this issue Oct 10, 2023
Merged
@pascalberger pascalberger changed the title ToAzureDevOpsArtifactResource should try-parse the artifact type case insensitive instead of case sensitive Artifact types should be handled case insensitive Oct 10, 2023
@pascalberger pascalberger added this to the 3.0.1 milestone Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
3.0.1
Development

Successfully merging a pull request may close this issue.

Make artifact type comparison case-insensitive christianbumann/Cake.AzureDevOps
2 participants
@pascalberger @christianbumann