Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TfsComment constructor which accepts internal comment type #124

Closed
pascalberger opened this issue Jul 16, 2019 · 0 comments · Fixed by #123
Closed

Remove TfsComment constructor which accepts internal comment type #124

pascalberger opened this issue Jul 16, 2019 · 0 comments · Fixed by #123
Assignees
@pascalberger
Labels
Breaking change
Milestone
0.4.0

Comments

@pascalberger
Copy link
Member

We should not export internal types and therefore remove the TfsComment constructor which accepts a CommentType
@pascalberger pascalberger added this to the vNext milestone Jul 16, 2019
@pascalberger pascalberger self-assigned this Jul 16, 2019
@pascalberger pascalberger mentioned this issue Jul 16, 2019
Merged
pascalberger added a commit that referenced this issue Jul 21, 2019
@pascalberger
Merge pull request #123 from pascalberger/feature/comment-type-internal
4b9087b 
(GH-124) Remove constructor which accepts internal comment type
@pascalberger pascalberger modified the milestones: 0.3.1, vNext Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pascalberger pascalberger

Labels
Breaking change
Projects
None yet
Milestone
0.4.0
Development

Successfully merging a pull request may close this issue.

(GH-124) Remove constructor which accepts internal comment type pascalberger/Cake.AzureDevOps
1 participant
@pascalberger