Throw specific exceptions

cake-contrib · Jan 22, 2023 · 8aca9ad · 8aca9ad
1 parent 026dab0
commit 8aca9ad
Show file tree

Hide file tree

Showing 11 changed files with 23 additions and 11 deletions.
diff --git a/src/Cake.AzureDevOps.Tests/Repos/PullRequest/AzureDevOpsPullRequestTests.cs b/src/Cake.AzureDevOps.Tests/Repos/PullRequest/AzureDevOpsPullRequestTests.cs
@@ -571,7 +571,7 @@ public void Should_Throw_If_AzureDevOps_Pull_Request_State_Is_Invalid()
                 // Then
                 result.ShouldNotBe(null);
                 result.IsExpected("SetStatus");
-                result.Message.ShouldBe("Unknown value");
+                result.Message.ShouldBe("The value of argument 'state' (123) is invalid for Enum type 'AzureDevOpsPullRequestStatusState'. (Parameter 'state')");
             }
 
             [Fact]

diff --git a/src/Cake.AzureDevOps/Pipelines/ArtifactResourceExtensions.cs b/src/Cake.AzureDevOps/Pipelines/ArtifactResourceExtensions.cs
@@ -20,7 +20,7 @@ public static AzureDevOpsArtifactResource ToAzureDevOpsArtifactResource(this Art
 
             if (!Enum.TryParse(artifactResource.Type, out AzurePipelinesArtifactType type))
             {
-                throw new Exception($"Unexpected value for artifact type '{artifactResource.Type}'");
+                throw new InvalidOperationException($"Unexpected value for artifact type '{artifactResource.Type}'");
             }
 
             return

diff --git a/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildQueryOrderExtensions.cs b/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildQueryOrderExtensions.cs
@@ -1,5 +1,6 @@
 namespace Cake.AzureDevOps.Pipelines
 {
+    using System.ComponentModel;
     using Microsoft.TeamFoundation.Build.WebApi;
 
     /// <summary>
@@ -22,7 +23,7 @@ public static BuildQueryOrder ToBuildQueryOrder(this AzureDevOpsBuildQueryOrder
                 AzureDevOpsBuildQueryOrder.QueueTimeAscending => BuildQueryOrder.QueueTimeAscending,
                 AzureDevOpsBuildQueryOrder.StartTimeDescending => BuildQueryOrder.StartTimeDescending,
                 AzureDevOpsBuildQueryOrder.StartTimeAscending => BuildQueryOrder.StartTimeAscending,
-                _ => throw new System.Exception("Unknown value"),
+                _ => throw new InvalidEnumArgumentException(nameof(queryOrder), (int)queryOrder, typeof(AzureDevOpsBuildQueryOrder)),
             };
         }
     }

diff --git a/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildResultExtensions.cs b/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildResultExtensions.cs
@@ -1,5 +1,6 @@
 namespace Cake.AzureDevOps.Pipelines
 {
+    using System.ComponentModel;
     using Microsoft.TeamFoundation.Build.WebApi;
 
     /// <summary>
@@ -21,7 +22,7 @@ public static BuildResult ToBuildResult(this AzureDevOpsBuildResult result)
                 AzureDevOpsBuildResult.PartiallySucceeded => BuildResult.PartiallySucceeded,
                 AzureDevOpsBuildResult.Failed => BuildResult.Failed,
                 AzureDevOpsBuildResult.Canceled => BuildResult.Canceled,
-                _ => throw new System.Exception("Unknown value"),
+                _ => throw new InvalidEnumArgumentException(nameof(result), (int)result, typeof(AzureDevOpsBuildResult)),
             };
         }
     }

diff --git a/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildStatusExtensions.cs b/src/Cake.AzureDevOps/Pipelines/AzureDevOpsBuildStatusExtensions.cs
@@ -1,6 +1,8 @@
 namespace Cake.AzureDevOps.Pipelines
 {
+    using System.ComponentModel;
     using Microsoft.TeamFoundation.Build.WebApi;
+    using Microsoft.VisualStudio.Services.TestManagement.TestPlanning.WebApi;
 
     /// <summary>
     /// Extensions for the <see cref="AzureDevOpsBuildStatus"/> class.
@@ -23,7 +25,7 @@ public static BuildStatus ToBuildStatus(this AzureDevOpsBuildStatus status)
                 AzureDevOpsBuildStatus.Postponed => BuildStatus.Postponed,
                 AzureDevOpsBuildStatus.NotStarted => BuildStatus.NotStarted,
                 AzureDevOpsBuildStatus.All => BuildStatus.All,
-                _ => throw new System.Exception("Unknown value"),
+                _ => throw new InvalidEnumArgumentException(nameof(status), (int)status, typeof(AzureDevOpsBuildStatus)),
             };
         }
     }

diff --git a/src/Cake.AzureDevOps/Pipelines/BuildResultExtensions.cs b/src/Cake.AzureDevOps/Pipelines/BuildResultExtensions.cs
@@ -1,5 +1,6 @@
 namespace Cake.AzureDevOps.Pipelines
 {
+    using System.ComponentModel;
     using Microsoft.TeamFoundation.Build.WebApi;
 
     /// <summary>
@@ -21,7 +22,7 @@ public static AzureDevOpsBuildResult ToAzureDevOpsBuildResult(this BuildResult r
                 BuildResult.PartiallySucceeded => AzureDevOpsBuildResult.PartiallySucceeded,
                 BuildResult.Failed => AzureDevOpsBuildResult.Failed,
                 BuildResult.Canceled => AzureDevOpsBuildResult.Canceled,
-                _ => throw new System.Exception("Unknown value"),
+                _ => throw new InvalidEnumArgumentException(nameof(result), (int)result, typeof(BuildResult)),
             };
         }
     }

diff --git a/src/Cake.AzureDevOps/Pipelines/BuildStatusExtensions.cs b/src/Cake.AzureDevOps/Pipelines/BuildStatusExtensions.cs
@@ -1,6 +1,8 @@
 namespace Cake.AzureDevOps.Pipelines
 {
+    using System.ComponentModel;
     using Microsoft.TeamFoundation.Build.WebApi;
+    using Microsoft.VisualStudio.Services.TestManagement.TestPlanning.WebApi;
 
     /// <summary>
     /// Extensions for the <see cref="BuildStatus"/> class.
@@ -23,7 +25,7 @@ public static AzureDevOpsBuildStatus ToAzureDevOpsBuildStatus(this BuildStatus s
                 BuildStatus.Postponed => AzureDevOpsBuildStatus.Postponed,
                 BuildStatus.NotStarted => AzureDevOpsBuildStatus.NotStarted,
                 BuildStatus.All => AzureDevOpsBuildStatus.All,
-                _ => throw new System.Exception("Unknown value"),
+                _ => throw new InvalidEnumArgumentException(nameof(status), (int)status, typeof(BuildStatus)),
             };
         }
     }

diff --git a/src/Cake.AzureDevOps/Pipelines/DefinitionQueueStatusExtensions.cs b/src/Cake.AzureDevOps/Pipelines/DefinitionQueueStatusExtensions.cs
@@ -1,5 +1,6 @@
 namespace Cake.AzureDevOps.Pipelines
 {
+    using System.ComponentModel;
     using Microsoft.TeamFoundation.Build.WebApi;
 
     /// <summary>
@@ -19,7 +20,7 @@ public static AzureDevOpsDefinitionQueueStatus ToAzureDevOpsDefinitionQueueStatu
                 DefinitionQueueStatus.Enabled => AzureDevOpsDefinitionQueueStatus.Enabled,
                 DefinitionQueueStatus.Paused => AzureDevOpsDefinitionQueueStatus.Paused,
                 DefinitionQueueStatus.Disabled => AzureDevOpsDefinitionQueueStatus.Disabled,
-                _ => throw new System.Exception("Unknown value"),
+                _ => throw new InvalidEnumArgumentException(nameof(status), (int)status, typeof(DefinitionQueueStatus)),
             };
         }
     }

diff --git a/src/Cake.AzureDevOps/Pipelines/TaskResultExtensions.cs b/src/Cake.AzureDevOps/Pipelines/TaskResultExtensions.cs
@@ -1,5 +1,6 @@
 namespace Cake.AzureDevOps.Pipelines
 {
+    using System.ComponentModel;
     using Microsoft.TeamFoundation.Build.WebApi;
 
     /// <summary>
@@ -22,7 +23,7 @@ public static AzureDevOpsTaskResult ToAzureDevOpsTaskResult(this TaskResult resu
                 TaskResult.Canceled => AzureDevOpsTaskResult.Canceled,
                 TaskResult.Skipped => AzureDevOpsTaskResult.Skipped,
                 TaskResult.Abandoned => AzureDevOpsTaskResult.Abandoned,
-                _ => throw new System.Exception("Unknown value"),
+                _ => throw new InvalidEnumArgumentException(nameof(result), (int)result, typeof(TaskResult)),
             };
         }
     }

diff --git a/src/Cake.AzureDevOps/Pipelines/TimelineRecordStateExtensions.cs b/src/Cake.AzureDevOps/Pipelines/TimelineRecordStateExtensions.cs
@@ -1,6 +1,8 @@
 namespace Cake.AzureDevOps.Pipelines
 {
+    using System.ComponentModel;
     using Microsoft.TeamFoundation.Build.WebApi;
+    using Microsoft.VisualStudio.Services.TestManagement.TestPlanning.WebApi;
 
     /// <summary>
     /// Extensions for the <see cref="TimelineRecordState"/> class.
@@ -19,7 +21,7 @@ public static AzureDevOpsTimelineRecordState ToAzureDevOpsTimelineRecordState(th
                 TimelineRecordState.Pending => AzureDevOpsTimelineRecordState.Pending,
                 TimelineRecordState.InProgress => AzureDevOpsTimelineRecordState.InProgress,
                 TimelineRecordState.Completed => AzureDevOpsTimelineRecordState.Completed,
-                _ => throw new System.Exception("Unknown value"),
+                _ => throw new InvalidEnumArgumentException(nameof(state), (int)state, typeof(TimelineRecordState)),
             };
         }
     }

diff --git a/src/Cake.AzureDevOps/Repos/PullRequest/AzureDevOpsPullRequestStatusStateExtensions.cs b/src/Cake.AzureDevOps/Repos/PullRequest/AzureDevOpsPullRequestStatusStateExtensions.cs
@@ -1,5 +1,6 @@
 namespace Cake.AzureDevOps.Repos.PullRequest
 {
+    using System.ComponentModel;
     using Microsoft.TeamFoundation.SourceControl.WebApi;
 
     /// <summary>
@@ -21,7 +22,7 @@ public static GitStatusState ToGitStatusState(this AzureDevOpsPullRequestStatusS
                 AzureDevOpsPullRequestStatusState.Succeeded => GitStatusState.Succeeded,
                 AzureDevOpsPullRequestStatusState.Failed => GitStatusState.Failed,
                 AzureDevOpsPullRequestStatusState.Error => GitStatusState.Error,
-                _ => throw new System.Exception("Unknown value"),
+                _ => throw new InvalidEnumArgumentException(nameof(state), (int)state, typeof(AzureDevOpsPullRequestStatusState)),
             };
         }
     }
-Original file line number
+Diff line change
@@ Expand Up @@
                 if (!Enum.TryParse(artifactResource.Type, out AzurePipelinesArtifactType type))
                 {
-                    throw new Exception($"Unexpected value for artifact type '{artifactResource.Type}'");
+                    throw new InvalidOperationException($"Unexpected value for artifact type '{artifactResource.Type}'");
                 }
                 return
@@ Expand Down @@