Skip to content

GH4834: Use --source for dotnet tool install on .NET 9+ #4835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
devlead merged 1 commit into from
May 19, 2026
Merged

GH4834: Use --source for dotnet tool install on .NET 9+ #4835

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/Cake.DotNetTool.Module/DotNetToolPackageInstaller.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,11 @@ private static ProcessArgumentBuilder GetArguments(
{
if (definition.Address != null)
{
#if NET9_0_OR_GREATER
arguments.Append("--source");
#else
arguments.Append("--add-source");
#endif
arguments.AppendQuoted(definition.Address.AbsoluteUri);
}

Expand Down
41 changes: 40 additions & 1 deletion tests/integration/Cake.DotNetTool.Module/Cake.DotNetTool.Module.cake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,46 @@ Task("Cake.DotNetTool.Module.Update")
CakeExecuteScript(scriptPath);
});

Task("Cake.DotNetTool.Module.Source.Setup")
.Does(() =>
{
var path = Paths.Temp.Combine("./Cake.DotNetTool.Module.Source");
CleanDirectory(path);
});

Task("Cake.DotNetTool.Module.Source.Install")
.IsDependentOn("Cake.DotNetTool.Module.Source.Setup")
.Does(() =>
{
// Given — explicit NuGet source (see https://github.com/cake-build/cake/issues/4834)
var scriptPath = Paths.Temp.Combine("./Cake.DotNetTool.Module.Source/").CombineWithFilePath("build.cake");
var script = "#tool \"dotnet:https://api.nuget.org/v3/index.json?package=GitVersion.Tool&version=6.6.2\"";
System.IO.File.WriteAllText(scriptPath.FullPath, script);

// When
CakeExecuteScript(scriptPath);
});

Task("Cake.DotNetTool.Module.Source.Update")
.IsDependentOn("Cake.DotNetTool.Module.Source.Install")
.Does(() =>
{
// Given — same source, newer tool version (see https://cakebuild.net/docs/writing-builds/tools/installing-tools)
var scriptPath = Paths.Temp.Combine("./Cake.DotNetTool.Module.Source/").CombineWithFilePath("build.cake");
var script = "#tool \"dotnet:https://api.nuget.org/v3/index.json?package=GitVersion.Tool&version=6.7.0\"";
System.IO.File.WriteAllText(scriptPath.FullPath, script);

// When
CakeExecuteScript(scriptPath);
});

Task("Cake.DotNetTool.Module.Source")
.IsDependentOn("Cake.DotNetTool.Module.Source.Setup")
.IsDependentOn("Cake.DotNetTool.Module.Source.Install")
.IsDependentOn("Cake.DotNetTool.Module.Source.Update");

Task("Cake.DotNetTool.Module")
.IsDependentOn("Cake.DotNetTool.Module.Setup")
.IsDependentOn("Cake.DotNetTool.Module.Install")
.IsDependentOn("Cake.DotNetTool.Module.Update");
.IsDependentOn("Cake.DotNetTool.Module.Update")
.IsDependentOn("Cake.DotNetTool.Module.Source");
Loading