Added 'ReadMe' property to NuGetPackSettings.#4724
Merged
Conversation
devlead
requested changes
Feb 20, 2026
Co-authored-by: Mattias Karlsson <mattias@devlead.se>
Co-authored-by: Mattias Karlsson <mattias@devlead.se>
Member
|
@squid-box your changes have been merged, thanks for your contribution 👍 |
This was referenced Mar 1, 2026
This was referenced Mar 2, 2026
This was referenced Mar 16, 2026
This was referenced Mar 30, 2026
This was referenced Apr 12, 2026
This was referenced Apr 23, 2026
This was referenced May 11, 2026
This was referenced May 20, 2026
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes #3517 which has been lingering for some years.
I considered doing extra validation on the Cake side, to ensure that the specified file exists in the Files property, but as this is validated by the NuGet pack command (
Error NU5039: The readme file '404.md' does not exist in the package.) I figured it best to keep this change simple.