prefer string.Join with a char #4566
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devlead
requested changes
Aug 27, 2025
Member
devlead
left a comment
devlead
left a comment
There was a problem hiding this comment.
Request Changes
Technical Review: ✅ Good modernization - using char instead of string for single-character separators is a performance optimization.
Process Issues:
- ❌ Missing Issue Link: This PR must be linked to an issue describing the modernization effort for .NET 8.0/9.0 compatibility
- ❌ Insufficient Description: PR description should explain the performance benefits and scope of changes
- ✅ CI Status: All checks passing
Recommendation: Please create an issue describing the .NET modernization effort and link it to this PR. Add a proper description explaining the performance benefits.
devlead
force-pushed
the
prefer-string.Join-with-a-char
branch
from
8c6363d to
f0875d3
Compare
Member
|
@SimonCropp your changes have been merged, thanks for your contribution 👍 |
This was referenced Nov 11, 2025
This was referenced Nov 11, 2025
This was referenced Nov 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.