GH4471: Improve script cache hash generation algorithm #4472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeertvanHorrik
changed the title
Contributor
Author
|
@devlead I know you initially worked on this feature, would you care doing a review? Thanks! |
gep13
reviewed
May 20, 2025
devlead
changed the title
2 tasks
devlead
requested changes
May 24, 2025
devlead
force-pushed
the
pr/script-cache-improvements
branch
from
5098ca6 to
6c6609b
Compare
Member
|
@GeertvanHorrik your changes have been merged, thanks for your contribution 👍 |
Contributor
Author
|
Thank you very much! Is there an estimate on when a new version of cake will be released (not a hard deadline, just want to have an idea when we might start using this |
Member
|
No firm dates yet, there are a couple of things we want to sort out first, after that find some time to do some testing and the release. There's a preview package available from our preview feed you could try out already today <add key="cake" value="https://pkgs.dev.azure.com/cake-build/Cake/_packaging/cake/nuget/v3/index.json" /> |
This was referenced Oct 5, 2025
This was referenced Oct 6, 2025
This was referenced Oct 15, 2025
This was referenced Oct 24, 2025
This was referenced Nov 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue we are seeing when running on a build agent that uses random folder names for each build. This PR allows cache re-usage by replacing the working directory inside the script lines before generating the hash.
Also added unit tests for:
For reference: #4471