feat: add comment injection #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a user has the comment extension installed, then it will handle highlighting certain aspects of the comments like TODOs, FIXMEs, etc
|
Oh neat, this looks like a good improvement to make. Do you know what the behaviour is if the comment extension isn't installed please? I'm guessing it just hilights as a make comment without any syntax, but need to be sure it doesn't cause an error |
|
@caius Yes, that's correct: if the comment extension is not installed, then the comment is highlighted as a comment without error. The similar change was merged for the languages bundled with Zed: zed-industries/zed#39884 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a user has the comment extension installed, then it will handle highlighting certain aspects of the comments like TODOs, FIXMEs, etc