Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat vite app #3

Merged
merged 11 commits into from
Oct 30, 2023
Merged

Feat vite app #3

merged 11 commits into from
Oct 30, 2023

Conversation

cahnory
Copy link
Owner

@cahnory cahnory commented Oct 29, 2023 •
edited
Loading

  • change react-sample app package into a lib package for reuse in multiple sample apps
  • setup vite-sample-app
  • add a readme to the react-sample lib recommending to collocate component with the app by default
  • move vite specific eslint settings from root to vite-sample-app? (not sure about that)

@cahnory cahnory marked this pull request as ready for review October 29, 2023 21:47
@cahnory cahnory merged commit 5b53c85 into main Oct 30, 2023
2 checks passed
@cahnory cahnory deleted the feat-vite-app branch October 30, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@cahnory