WIP for test helper implementation #1
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafreeman
force-pushed
the
cfreeman/implement-testing-rfc
branch
from
66602a3
to
25457a3
Compare
rwjblue
reviewed
Mar 21, 2022
addon-test-support/@ember/test-helpers/-internal/get-component-manager.ts
Outdated
Show resolved
Hide resolved
cafreeman
commented
Mar 21, 2022
addon-test-support/@ember/test-helpers/-internal/render-settled.ts
Outdated
Show resolved
Hide resolved
rwjblue
reviewed
Mar 21, 2022
addon-test-support/@ember/test-helpers/-internal/render-settled.ts
Outdated
Show resolved
Hide resolved
addon-test-support/@ember/test-helpers/-internal/render-settled.ts
Outdated
Show resolved
Hide resolved
addon-test-support/@ember/test-helpers/-internal/render-settled.ts
Outdated
Show resolved
Hide resolved
addon-test-support/@ember/test-helpers/-internal/get-component-manager.ts
Outdated
Show resolved
Hide resolved
tests/integration/settled-test.js
Outdated
| @@ -163,6 +164,15 @@ module('settled real-world scenarios', function (hooks) { | |||
| assert.equal(this.element.textContent, 'async value'); | |||
| }); | |||
|
|
|||
| test('rerender', async function (assert) { | |||
There was a problem hiding this comment.
need more rerender tests, discussed in person
cafreeman
force-pushed
the
cfreeman/implement-testing-rfc
branch
2 times, most recently
from
655598e
to
4a3814e
Compare
cafreeman
force-pushed
the
cfreeman/implement-testing-rfc
branch
from
4a3814e
to
3abf41f
Compare
cafreeman
force-pushed
the
cfreeman/implement-testing-rfc
branch
from
22f8a0f
to
49d28f5
Compare
cafreeman
force-pushed
the
cfreeman/implement-testing-rfc
branch
2 times, most recently
from
f85aa0b
to
db471ec
Compare
Co-authored-by: Robert Jackson <[email protected]>
Co-authored-by: Robert Jackson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.