Skip to content

implement n-ary function types, driven by syntactic form of declaration.#80

Merged
crusso merged 3 commits intomasterfrom
naryfuncs
Nov 26, 2018
Merged

implement n-ary function types, driven by syntactic form of declaration.#80
crusso merged 3 commits intomasterfrom
naryfuncs

Conversation

@crusso
Copy link
Contributor

@crusso crusso commented Nov 22, 2018

Use new ParT syntax (only) to distinguish n-ary args from first class tuples when necessary.

All tests pass, but I'm not yet convinced await and async translations are entirely safe.

Fixed some lurking bugs in naive await translation due to poor precedence of -->.

@crusso
implement n-ary function types, driven by syntactic form of declaration.
d3f0968 
Use new ParT syntax (only) to distinguish n-ary args from first class tuples when necessary.

All tests pass, but I'm not yet convinced await and async translations are entirely safe.

Fixed some lurking bugs in naive await translation due to poor precedence of -->.
@crusso crusso requested review from nomeata and rossberg November 22, 2018 19:48
@nomeata
Copy link
Contributor

nomeata commented Nov 26, 2018

Read through the diff, looks good to me.

@nomeata
Copy link
Contributor

nomeata commented Nov 26, 2018

I updated the test output on this branch.

rossberg
rossberg reviewed Nov 26, 2018
View reviewed changes
Copy link
Contributor

@rossberg rossberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, mostly nits.

@crusso
address Andreas review, in particular:
9ef1e5e 
rename pack/unpack to seq/as_seq
rename T.S and T.A to T.Returns and T.Promises
rossberg
rossberg approved these changes Nov 26, 2018
View reviewed changes
src/syntax.ml
let seqT ts =
match ts with
| [t] -> t
| ts -> {Source.it = TupT ts; at = Source.no_region; Source.note = ()}
Copy link
Contributor

@rossberg rossberg Nov 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: qualifying the first label is sufficient, so note should be enough. But why not do Source.(TupT ts @@ no_region)?

@crusso crusso merged commit 4f03117 into master Nov 26, 2018
@crusso crusso deleted the naryfuncs branch November 26, 2018 16:27
dfinity-bot added a commit that referenced this pull request Oct 28, 2020
@dfinity-bot
niv candid: update a1dcbad4 -> 3e3ad95a
78824ca 
## Changelog for candid:
Branch: 
Commits: [dfinity/candid@a1dcbad4...3e3ad95a](dfinity/candid@a1dcbad...3e3ad95)

* [`119703ba`](dfinity/candid@119703b) [Spec] Relax LEB128 decoding ([dfinity/candid⁠#79](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/79))
* [`10f08432`](dfinity/candid@10f0843) Update prim.test.did
* [`b2524816`](dfinity/candid@b252481) parser for test suite ([dfinity/candid⁠#78](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/78))
* [`71bf6e76`](dfinity/candid@71bf6e7) release 0.5.2 ([dfinity/candid⁠#80](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/80))
* [`b9f387e3`](dfinity/candid@b9f387e) test suite for JS ([dfinity/candid⁠#81](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/81))
* [`9e5dc775`](dfinity/candid@9e5dc77) Release ([dfinity/candid⁠#82](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/82))
* [`1df9d2d7`](dfinity/candid@1df9d2d) more candid test data ([dfinity/candid⁠#83](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/83))
* [`9e4156d9`](dfinity/candid@9e4156d) fix newtype ([dfinity/candid⁠#85](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/85))
* [`6880a430`](dfinity/candid@6880a43) display for types ([dfinity/candid⁠#86](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/86))
* [`04b1b068`](dfinity/candid@04b1b06) release ([dfinity/candid⁠#87](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/87))
* [`117c6436`](dfinity/candid@117c643) Refactor Lexer ([dfinity/candid⁠#89](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/89))
* [`0a5789f9`](dfinity/candid@0a5789f) fix value pretty printer ([dfinity/candid⁠#92](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/92))
* [`9f35a5aa`](dfinity/candid@9f35a5a) refactor error ([dfinity/candid⁠#94](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/94))
* [`2e742927`](dfinity/candid@2e74292) Parse annvals in textual format ([dfinity/candid⁠#93](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/93))
* [`0a144c79`](dfinity/candid@0a144c7) use principal from ic-types ([dfinity/candid⁠#84](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/84))
* [`01412b14`](dfinity/candid@01412b1) release ([dfinity/candid⁠#95](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/95))
* [`f540df54`](dfinity/candid@f540df5) release ([dfinity/candid⁠#98](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/98))
* [`798675d8`](dfinity/candid@798675d) Add generic functions to encode/decode around a tuple ([dfinity/candid⁠#99](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/99))
* [`0d26e568`](dfinity/candid@0d26e56) release ([dfinity/candid⁠#100](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/100))
* [`191b6f1f`](dfinity/candid@191b6f1) Reset record_nesting_depth after each value ([dfinity/candid⁠#101](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/101))
* [`8e7be65d`](dfinity/candid@8e7be65) fix record ([dfinity/candid⁠#103](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/103))
* [`159533b2`](dfinity/candid@159533b) Update construct.test.did
* [`a6ea0991`](dfinity/candid@a6ea099) add service initialization parameters ([dfinity/candid⁠#88](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/88))
* [`3a1f56fa`](dfinity/candid@3a1f56f) refactor: sort dependencies and add traits for error types ([dfinity/candid⁠#105](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/105))
* [`89df78ee`](dfinity/candid@89df78e) support service constructor ([dfinity/candid⁠#106](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/106))
* [`738d5ed4`](dfinity/candid@738d5ed) fix for actor class codegen ([dfinity/candid⁠#107](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/107))
* [`97ba7a0f`](dfinity/candid@97ba7a0) export init args in js ([dfinity/candid⁠#108](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/108))
* [`d4e00adc`](dfinity/candid@d4e00ad) fix js init export ([dfinity/candid⁠#109](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/109))
* [`c1662abe`](dfinity/candid@c1662ab) [spec] Reverse subtyping ([dfinity/candid⁠#110](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/110))
* [`713595be`](dfinity/candid@713595b) The “reverse variant extension rule” is redundand ([dfinity/candid⁠#113](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/113))
* [`79d49a01`](dfinity/candid@79d49a0) Spec: Opt decoding also from non-opt values ([dfinity/candid⁠#114](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/114))
* [`2cfc0ecf`](dfinity/candid@2cfc0ec) improve pretty printing for values ([dfinity/candid⁠#116](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/116))
* [`8fafe345`](dfinity/candid@8fafe34) Un-rename Soundness document ([dfinity/candid⁠#115](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/115))
* [`8e6fc502`](dfinity/candid@8e6fc50) Bump spec version ([dfinity/candid⁠#112](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/112))
* [`7cedebcb`](dfinity/candid@7cedebc) fix clippy ([dfinity/candid⁠#117](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/117))
* [`a732a639`](dfinity/candid@a732a63) Candid UI Canister ([dfinity/candid⁠#111](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/111))
* [`d97b271c`](dfinity/candid@d97b271) disable pretty printing for large vectors ([dfinity/candid⁠#118](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/118))
* [`aceb7f92`](dfinity/candid@aceb7f9) derive candid type for functions ([dfinity/candid⁠#119](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/119))
* [`c3dc0ad7`](dfinity/candid@c3dc0ad) rename derived code for CDK ([dfinity/candid⁠#120](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/120))
* [`d1f8de7d`](dfinity/candid@d1f8de7) release ([dfinity/candid⁠#121](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/121))
* [`3e3ad95a`](dfinity/candid@3e3ad95) remove multi-line string in test suites ([dfinity/candid⁠#125](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/125))
dfinity-bot added a commit that referenced this pull request Jan 11, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 72d2bc28
4b27eb1 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...72d2bc28](dfinity/ic-wasm@48db35e...72d2bc2)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
dfinity-bot added a commit that referenced this pull request Jan 14, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 707016c2
b7e9906 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...707016c2](dfinity/ic-wasm@48db35e...707016c)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
dfinity-bot added a commit that referenced this pull request Jan 18, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 707016c2
09d75c0 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...707016c2](dfinity/ic-wasm@48db35e...707016c)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
dfinity-bot added a commit that referenced this pull request Jan 21, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 707016c2
b5127c6 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...707016c2](dfinity/ic-wasm@48db35e...707016c)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
dfinity-bot added a commit that referenced this pull request Jan 22, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 707016c2
4d088bd 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...707016c2](dfinity/ic-wasm@48db35e...707016c)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
dfinity-bot added a commit that referenced this pull request Jan 23, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 707016c2
d70a94d 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...707016c2](dfinity/ic-wasm@48db35e...707016c)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
dfinity-bot added a commit that referenced this pull request Jan 24, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 707016c2
95ae524 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...707016c2](dfinity/ic-wasm@48db35e...707016c)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
dfinity-bot added a commit that referenced this pull request Jan 28, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 41bb2f59
8778061 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...41bb2f59](dfinity/ic-wasm@48db35e...41bb2f5)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
dfinity-bot added a commit that referenced this pull request Jan 29, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
de93c5e 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Jan 30, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
97d8e68 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Feb 5, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
f358aa8 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Feb 7, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
7244cdc 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Feb 18, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
9f320ff 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Feb 24, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
3cb2dd6 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Mar 4, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
79d74a1 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Mar 7, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
7b7d022 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Mar 8, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
0fce842 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Mar 17, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
29b57a8 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Mar 20, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
6990f0d 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Mar 22, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
a7b06cc 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
dfinity-bot added a commit that referenced this pull request Mar 27, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c
a5ede8a 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
mergify bot pushed a commit that referenced this pull request Mar 30, 2025
@dfinity-bot
niv ic-wasm: update 48db35ee -> 4c52e75c (#4844)
ec647f5 
## Changelog for ic-wasm:
Branch: main
Commits: [dfinity/ic-wasm@48db35ee...4c52e75c](dfinity/ic-wasm@48db35e...4c52e75)

* [`bdc074a8`](dfinity/ic-wasm@bdc074a) fix: limit_resource works with wasm64 ([dfinity/ic-wasm⁠#79](https://github.com/dfinity/ic-wasm/issues/79))
* [`72d2bc28`](dfinity/ic-wasm@72d2bc2) Validate the manipulated module before emitting it and give a warning if that fails.  ([dfinity/ic-wasm⁠#80](https://github.com/dfinity/ic-wasm/issues/80))
* [`707016c2`](dfinity/ic-wasm@707016c) Build musl target with docker alpine in release workflow ([dfinity/ic-wasm⁠#1](https://github.com/dfinity/ic-wasm/issues/1)) ([dfinity/ic-wasm⁠#82](https://github.com/dfinity/ic-wasm/issues/82))
* [`41bb2f59`](dfinity/ic-wasm@41bb2f5) chore: Allow sign_with_schnorr ([dfinity/ic-wasm⁠#83](https://github.com/dfinity/ic-wasm/issues/83))
* [`4c52e75c`](dfinity/ic-wasm@4c52e75) fix: Feature wasm-opt ([dfinity/ic-wasm⁠#84](https://github.com/dfinity/ic-wasm/issues/84))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@nomeata nomeata nomeata approved these changes

@rossberg rossberg rossberg approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@crusso @nomeata @rossberg