Skip to content

Check overflow of reference and closure tables #366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nomeata merged 1 commit into from
May 10, 2019
Merged

Check overflow of reference and closure tables #366

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/compile.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,12 @@ module ElemHeap = struct
reference table *)
let remember_reference env : G.t =
Func.share_code1 env "remember_reference" ("ref", I32Type) [I32Type] (fun env get_ref ->
(* Check table space *)
get_ref_ctr ^^
compile_unboxed_const max_references ^^
G.i (Compare (Wasm.Values.I32 I64Op.LtU)) ^^
E.else_trap_with env "Reference table full" ^^

(* Return index *)
get_ref_ctr ^^

Expand Down Expand Up @@ -811,6 +817,12 @@ module ClosureTable = struct
reference table *)
let remember_closure env : G.t =
Func.share_code1 env "remember_closure" ("ptr", I32Type) [I32Type] (fun env get_ptr ->
(* Check table space *)
get_counter ^^
compile_unboxed_const (Int32.sub max_entries 1l) ^^
G.i (Compare (Wasm.Values.I32 I64Op.LtU)) ^^
E.else_trap_with env "Closure table full" ^^

(* Return index *)
get_counter ^^
compile_add_const 1l ^^
Expand Down