Skip to content

niv ic-hs: update 0f87c270 -> 20e23e1a #3615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 6 commits into from
Dec 6, 2022
Merged

niv ic-hs: update 0f87c270 -> 20e23e1a #3615

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bc20f15
niv ic-hs: update 0f87c270 -> 20e23e1a
dfinity-bot Dec 2, 2022
494a9b5
this works now on `ic-ref`
ggreif Dec 5, 2022
37e5495
allow for more wait before the first callback
ggreif Dec 5, 2022
7de6da1
guard agains overcounting
ggreif Dec 5, 2022
4aea754
better to simply disable this for ic-ref
ggreif Dec 6, 2022
ac37ca0
Merge branch 'master' into update/ic-hs-0f87c27013c46454b4d8898e5893a…
mergify[bot] Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions nix/sources.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,10 +40,10 @@
"homepage": "",
"owner": "dfinity",
"repo": "ic-hs",
"rev": "0f87c27013c46454b4d8898e5893a8d64a01627d",
"sha256": "0vn6w86fgmy40nyf9zpn97xfhxnkifhfsa4hb6pshvyw3i3j8r3f",
"rev": "20e23e1ab496cbd2bc3b687a71e381edc8299da1",
"sha256": "1cmync8lqfi6nfmvdga091cdns1y32l8ypmbvlb5l850zy8l3h1w",
"type": "tarball",
"url": "https://github.com/dfinity/ic-hs/archive/0f87c27013c46454b4d8898e5893a8d64a01627d.tar.gz",
"url": "https://github.com/dfinity/ic-hs/archive/20e23e1ab496cbd2bc3b687a71e381edc8299da1.tar.gz",
"url_template": "https://github.com/<owner>/<repo>/archive/<rev>.tar.gz"
},
"libtommath": {
Expand Down
2 changes: 1 addition & 1 deletion test/run-drun/heartbeat.mo
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ actor {
while (count < max) {
ignore await raw_rand(); // yield to scheduler
attempts += 1;
if (attempts >= 50 and count == 0)
if (attempts >= 200 and count == 0)

@nomeata nomeata Dec 5, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yuck, that's precisely the kind of issues I was worried about with timer-based heartbeats. It's an IC simulation, we should be able to control the scheduling independent of walltime! (Also pinging @mraszyk)

@ggreif ggreif Dec 6, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, a synthetic clock would be useful.

throw Prim.error("he's dead Jim");
};
Prim.debugPrint(debug_show {count});
Expand Down
3 changes: 2 additions & 1 deletion test/run-drun/ok/heartbeat.ic-ref-run.ok
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@
=> update install_code(record {arg = blob ""; kca_xin = blob "\00asm\01\00\00\00\0...
<= replied: ()
=> update go()
<= rejected (RC_CANISTER_REJECT): he's dead Jim
debug.print: {count = 10}
<= replied: ()