SDK-166 Modular access control (confine all checks to ServerActor module)#350
Merged
matthewhammer merged 1 commit intomasterfrom Apr 26, 2019
Merged
SDK-166 Modular access control (confine all checks to ServerActor module)#350matthewhammer merged 1 commit intomasterfrom
ServerActor module)#350matthewhammer merged 1 commit intomasterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reorganizes the API of the service, and the internal API of the
Modelclass, with respect to the placement and checking ofPublicKeyparameters and fields:UserIds, for any role-based functionregistrarAddProducercall, etc.)ServerActormodule; no checks happen inServerModelany longer; the bulk of module's API need not usePublicKeys at all now, so they are gone now.ServerActormodule performs operations using theServerModelAPISome future access control could be added (e.g., for retailer reservations) when those features are finished. Based on the existing access control checks in this PR, it should be clear how to continue the idiom for these future checks.