Rename: closure*table -> continuation*table#2690
Conversation
|
This PR does not affect the produced WebAssembly code. |
| // Similar to `mark_root_mutbox_fields`, `closure_table_ptr_loc` is in static heap so it | ||
| // will be readable when we unthread closure table | ||
| thread(closure_table_ptr_loc); | ||
| if (*continuation_table_ptr_loc).unskew() >= heap_base as usize { |
There was a problem hiding this comment.
There was a problem hiding this comment.
@crusso From gc point of view closure table is just a heap object that is also a root. We don't make any assumptions on the type of it, or how many elements it has, or whether elements are scalar or pointers.
| @@ -7264,11 +7264,11 @@ and compile_exp (env : E.t) ae exp = | |||
|
|
|||
| | OtherPrim "rts_callback_table_count", [] -> | |||
There was a problem hiding this comment.
Ha! Maybe we should have called it the callback table! But let's stick with this for now.
There was a problem hiding this comment.
Do we want to rename the external Prims too, or just leave them for now? I'm actually ok with either since people aren't supposed to rely on these names... will leave it up to you.
There was a problem hiding this comment.
I'll leave them, this is an external interface.
ggreif
added
DO-NOT-MERGE
automerge-squash
4 participants
This is a wholesale rename, in the spirit of #2663 (comment)