Conversation
|
This PR does not affect the produced WebAssembly code. |
Changelog.md
Outdated
| 2. Heap size is more than 3 GiB | ||
|
|
||
| (1) is to make sure we don't do GC on tiny heaps or after only small amounts of allocation. (2) is to make sure that | ||
| (i) is to make sure we don't do GC on tiny heaps or after only small amounts of allocation. (ii) is to make sure that |
There was a problem hiding this comment.
These refer to the (1) and (2) above, why confuse the reader by spelling them Roman here?
There was a problem hiding this comment.
Since the Roman numerals come from GitHub's braindead CSS, the HTML should be fine elsewhere. So I went back to the original.
|
Because the renderer shows it as "i" and "ii". See image above.
…On 7/29/21, Andreas Rossberg ***@***.***> wrote:
@rossberg commented on this pull request.
>
1. Heap grows more than 50% and 10 MiB since the last GC, or
2. Heap size is more than 3 GiB
- (1) is to make sure we don't do GC on tiny heaps or after only small
amounts of allocation. (2) is to make sure that
+ (i) is to make sure we don't do GC on tiny heaps or after only small
amounts of allocation. (ii) is to make sure that
These refer to the (1) and (2) above, why confuse the reader by spelling
them Roman here?
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#2689 (review)
|
|
But you are right, if somebody reads the unrendered Looks like this is the problem: github/markup#991 Happy to revert that part if you wish. |
|
In that case, can't you change the 1./2. to Roman as well? |
Sadly, no. I reverted my change. |
No description provided.