Skip to content

Comments

Tweak Changelog.md#2689

Merged
mergify[bot] merged 5 commits intomasterfrom
gabor/changelog
Jul 29, 2021
Merged

Tweak Changelog.md#2689
mergify[bot] merged 5 commits intomasterfrom
gabor/changelog

Conversation

@ggreif
Copy link
Contributor

@ggreif ggreif commented Jul 29, 2021

No description provided.

@dfinity-ci
Copy link

This PR does not affect the produced WebAssembly code.

@ggreif ggreif requested a review from osa1 July 29, 2021 12:37
Changelog.md Outdated
2. Heap size is more than 3 GiB

(1) is to make sure we don't do GC on tiny heaps or after only small amounts of allocation. (2) is to make sure that
(i) is to make sure we don't do GC on tiny heaps or after only small amounts of allocation. (ii) is to make sure that
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These refer to the (1) and (2) above, why confuse the reader by spelling them Roman here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the Roman numerals come from GitHub's braindead CSS, the HTML should be fine elsewhere. So I went back to the original.

@ggreif
Copy link
Contributor Author

ggreif commented Jul 29, 2021 via email

@ggreif
Copy link
Contributor Author

ggreif commented Jul 29, 2021

But you are right, if somebody reads the unrendered .md it is equally confusing now. Will the primary reader audience see the text or the rendering?

Looks like this is the problem: github/markup#991

Happy to revert that part if you wish.

@rossberg
Copy link
Contributor

In that case, can't you change the 1./2. to Roman as well?

@ggreif
Copy link
Contributor Author

ggreif commented Jul 29, 2021

In that case, can't you change the 1./2. to Roman as well?

Sadly, no. i. para doesn't count as an ordered list item in markdown.

I reverted my change.

@ggreif ggreif added the automerge-squash When ready, merge (using squash) label Jul 29, 2021
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A change to Changelog.md? I can handle that!

@mergify mergify bot merged commit 2051bfb into master Jul 29, 2021
@mergify mergify bot deleted the gabor/changelog branch July 29, 2021 17:19
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Jul 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants