Guard against Motoko 32 bit values overflowing the compiler's 31-bit arithmetic#2686
Merged
mergify[bot] merged 2 commits intomasterfrom Jul 28, 2021
Merged
Guard against Motoko 32 bit values overflowing the compiler's 31-bit arithmetic#2686mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
…arithmetic since `of_int` returns an `int`, this has not enough precision (31 bits) when the compiler is 32-bit, e.g. on JS (Motoko Playground) In long term we should get rid of `of_int`.
|
This PR does not affect the produced WebAssembly code. |
Contributor
|
Nice catch! |
chenyan-dfinity
approved these changes
Jul 28, 2021
Contributor
chenyan-dfinity
left a comment
chenyan-dfinity
left a comment
There was a problem hiding this comment.
This works in the playground!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since
NumType.of_intreturns anint, this has not enough precision (just 31 bits) whenthe compiler is 32-bit, e.g. on JS (Motoko Playground)
This patch switches to using
Big_intinstead.Fixes #2671.