Skip to content

Comments

niv ic-hs: update 947d376a -> f3985321#2654

Merged
mergify[bot] merged 1 commit intomasterfrom
update/ic-hs-947d376a2936bebec447f9fc558d2b25dd1cbcf8
Jul 13, 2021
Merged

niv ic-hs: update 947d376a -> f3985321#2654
mergify[bot] merged 1 commit intomasterfrom
update/ic-hs-947d376a2936bebec447f9fc558d2b25dd1cbcf8

Conversation

@dfinity-bot
Copy link
Contributor

@dfinity-bot dfinity-bot commented Jul 7, 2021

Changelog for ic-hs:

Branch: master
Commits: dfinity/ic-hs@947d376a...f3985321

@dfinity-bot dfinity-bot added the automerge-squash When ready, merge (using squash) label Jul 7, 2021
Copy link
Contributor

@mergify mergify bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This bot trusts that bot

@dfinity-ci
Copy link

This PR does not affect the produced WebAssembly code.

@ggreif
Copy link
Contributor

ggreif commented Jul 8, 2021

@nomeata candid-0.2 seems to be more verbose than its predecessor. Is there a --concise (or such) flag to revert the chattiness (for diff-ing purposes), or should I accept all the changes?

@dfinity-bot dfinity-bot force-pushed the update/ic-hs-947d376a2936bebec447f9fc558d2b25dd1cbcf8 branch from 703eb71 to 7e24c91 Compare July 10, 2021 00:03
@nomeata
Copy link
Contributor

nomeata commented Jul 12, 2021

Hmm, it’s probably printing the result of decodeVals (nomeata/haskell-candid@01157c5#diff-a70b08fdc8d7e85a721cc42160181f1c12dcfedbe6c08d298fd5f5ac71f24097R27) which is now returning two values, and we only want to return the send (the [Value]). Somewhere in ic-ref-run we need to throw in a snd, so let’s not merge this yet.

@nomeata
Copy link
Contributor

nomeata commented Jul 12, 2021

Tracked in dfinity/ic-hs#21

## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@947d376a...f3985321](dfinity/ic-hs@947d376...f398532)

* [`996511ad`](dfinity/ic-hs@996511a) Bump Candid to version 0.2 ([dfinity/ic-hs⁠#20](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/ic-hs/issues/20))
* [`f3985321`](dfinity/ic-hs@f398532) ic-ref-run: Pretty print candid values without type table ([dfinity/ic-hs⁠#22](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/ic-hs/issues/22))
@dfinity-bot dfinity-bot changed the title niv ic-hs: update 947d376a -> 996511ad niv ic-hs: update 947d376a -> f3985321 Jul 13, 2021
@dfinity-bot dfinity-bot force-pushed the update/ic-hs-947d376a2936bebec447f9fc558d2b25dd1cbcf8 branch from 7e24c91 to e9f5eea Compare July 13, 2021 00:03
@mergify mergify bot merged commit f634a2a into master Jul 13, 2021
@mergify mergify bot deleted the update/ic-hs-947d376a2936bebec447f9fc558d2b25dd1cbcf8 branch July 13, 2021 00:36
@mergify mergify bot removed the automerge-squash When ready, merge (using squash) label Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants