Skip to content

Remove unused end_of_heap global #2634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 2 commits into from
Jun 30, 2021
Merged

Remove unused end_of_heap global #2634

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a66f04
Remove unused end_of_heap global
osa1 Jun 30, 2021
9803cd9
Merge branch 'master' into osa1/unused_global
mergify[bot] Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/codegen/compile.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -851,10 +851,6 @@ module Heap = struct
let get_heap_base env =
G.i (GlobalGet (nr (E.get_global env "__heap_base")))

let register_globals env =
(* end-of-heap pointer, we set this to __heap_base upon start *)
E.add_global32 env "end_of_heap" Mutable 0xDEADBEEFl

let get_total_allocation env =
E.call_import env "rts" "get_total_allocations"

Expand Down Expand Up @@ -8159,7 +8155,6 @@ and conclude_module env start_fi_o =
let compile mode rts (prog : Ir.prog) : Wasm_exts.CustomModule.extended_module =
let env = E.mk_global mode rts IC.trap_with Lifecycle.end_ in

Heap.register_globals env;
Stack.register_globals env;

IC.system_imports env;
Expand Down