Fix sleb128_decode overflow checking#2630
Merged
mergify[bot] merged 2 commits intomasterfrom Jun 29, 2021
Merged
Conversation
Fixes #2625 New tests added for checking edge cases + overflows.
|
This PR does not affect the produced WebAssembly code. |
crusso
reviewed
Jun 29, 2021
Contributor
crusso
left a comment
There was a problem hiding this comment.
LGTM.
Are the option returning versions used on hot paths? Would it be worth writing ones that either panic on overflow or return boolean out parameter indicating success instead of allocating an option?
Contributor
Author
I didn't check the generated code, but in CanCan backend benchmark this reduced cycles by 0.00041% (42,055,832 to 42,055,656). |
crusso
approved these changes
Jun 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2625
Refactors decode functions to allow checking overflows.
New tests added for checking edge cases + overflows.