Skip to content

Comments

AST-70: Eliminate 1-tuples#263

Merged
ggreif merged 3 commits intomasterfrom
1-tuple
Mar 25, 2019
Merged

AST-70: Eliminate 1-tuples#263
ggreif merged 3 commits intomasterfrom
1-tuple

Conversation

@rossberg
Copy link
Contributor

No description provided.

@rossberg rossberg requested a review from ggreif March 22, 2019 06:49
Copy link
Contributor

@ggreif ggreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

This is https://dfinity.atlassian.net/browse/AST-70 by the way, so you should prefix the pull request before merging.

Note: The source ranges change (in the right direction) in data-params.as, so you should make accept.

@crusso
Copy link
Contributor

crusso commented Mar 22, 2019

That's ok for the source, but do we need to rule them out in the IR as well?

@rossberg
Copy link
Contributor Author

@crusso, do you mean adding some extra checks to check_ir?

@nomeata
Copy link
Contributor

nomeata commented Mar 22, 2019

That's ok for the source, but do we need to rule them out in the IR as well?

I don’t think we need to rule it out: In the IR functions have an explicit arity, so there is no confusion, and we can support them just fine, and it might be useful for some transformations to be more uniform.

In any case, we can do that separately, if we want.

@crusso
Copy link
Contributor

crusso commented Mar 25, 2019

FIne by me.

@ggreif ggreif merged commit 91d6bf3 into master Mar 25, 2019
@ggreif ggreif deleted the 1-tuple branch March 25, 2019 17:17
@ggreif ggreif changed the title Eliminate 1-tuples AST-70: Eliminate 1-tuples Mar 25, 2019
dfinity-bot added a commit that referenced this pull request Jun 11, 2021
mergify bot pushed a commit that referenced this pull request Jun 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants