Compacting GC: get object size before threading fields#2622
Merged
mergify[bot] merged 2 commits intomasterfrom Jun 23, 2021
Merged
Compacting GC: get object size before threading fields#2622mergify[bot] merged 2 commits intomasterfrom
mergify[bot] merged 2 commits intomasterfrom
Conversation
This fixes a bug when an object refers to itself. If we thread the fields first, by the time we get the object's size the header will be gone. So we need to get the size first, then thread the fields. Bug caught by #2573 and a test will be added with that PR.
crusso
approved these changes
Jun 23, 2021
|
This PR does not affect the produced WebAssembly code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bug when an object refers to itself. If we thread the
fields first, by the time we get the object's size the header will be
gone. So we need to get the size first, then thread the fields.
Bug caught by #2573 and a test will be added with that PR.