Closed
Conversation
I believe destructured is the correct word here.
|
This PR does not affect the produced WebAssembly code. |
Contributor
Author
|
Destructuring assignment is a specialized term in JavaScript and PHP
documentation, however I am not familiar with how things are represented in
other languages.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment
https://www.php.net/manual/en/migration71.new-features.php#migration71.new-features.symmetric-array-destructuring
…On Mon, Jun 21, 2021 at 7:15 AM Claudio Russo ***@***.***> wrote:
***@***.**** commented on this pull request.
I actually prefer deconstructed since destructuring implies destruction of
the original value (which is not the case).
@rossberg <https://github.com/rossberg>?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2610 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZBJWGE2TJD6YHFFYHCTJTTT4NOPANCNFSM467KHM2Q>
.
|
Contributor
|
"Destructuring" is the established term in a number of communities, so I'm fine with using it. |
Merged
Contributor
|
Superseeded by #2620 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe destructured is the correct word here.