Skip to content

Comments

Fix issue #2319 (crash on import of candid class)#2605

Merged
crusso merged 9 commits intomasterfrom
claudio/issue-2319
Jun 22, 2021
Merged

Fix issue #2319 (crash on import of candid class)#2605
crusso merged 9 commits intomasterfrom
claudio/issue-2319

Conversation

@crusso
Copy link
Contributor

@crusso crusso commented Jun 18, 2021

  • errors, doesn't crash, on import of candid service class
  • improves on UnsupportedCandid error reporting, adding source location and message.

@dfinity-ci
Copy link

This PR does not affect the produced WebAssembly code.

@crusso crusso marked this pull request as ready for review June 21, 2021 20:42
@crusso crusso linked an issue Jun 21, 2021 that may be closed by this pull request
@crusso
Copy link
Contributor Author

crusso commented Jun 21, 2021

@chenyan-dfinity PTAL
BTW, do you know if we actually type-check (i.e. kind-check) the imported candid file before or during import? There might be a an unlikely, but possible, security hole if we don't.

Copy link
Contributor

@chenyan-dfinity chenyan-dfinity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@crusso crusso merged commit 09056ec into master Jun 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bad error message when importing .did that isn't a service

3 participants