Reworded to make a bit easier to follow#2579
Closed
cPlayIt wants to merge 5 commits intocaffeinelabs:masterfrom
Closed
Reworded to make a bit easier to follow#2579cPlayIt wants to merge 5 commits intocaffeinelabs:masterfrom
cPlayIt wants to merge 5 commits intocaffeinelabs:masterfrom
Conversation
|
This PR does not affect the produced WebAssembly code. |
crusso
approved these changes
Jun 11, 2021
Contributor
crusso
left a comment
crusso
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for the improvement!
Contributor
Author
|
Thanks, my first pull request on GitHub :)
I have a fix for the sdk web site as well, I know why the right hand TOC
isn't sticky as intended.
(Why it scrolls with rest of page erratically)
…On Fri, Jun 11, 2021, 4:50 AM Claudio Russo ***@***.***> wrote:
***@***.**** approved this pull request.
Looks good to me. Thanks for the improvement!
------------------------------
In doc/modules/language-guide/pages/basic-concepts.adoc
<#2579 (comment)>:
> @@ -199,8 +199,7 @@ Other languages that lack lexical scoping may give a different meaning to this p
However, modern languages universally favor lexical scoping, the meaning given here.
Aside from mathematical clarity, the chief practical benefit of lexical scoping is _security_, and its use in building compositionally-secure systems.
-Specifically, {proglang} gives very strong composition properties: Nesting your program within one you do not trust cannot, for example, arbitrarily re-associate your variable
-occurrences with different meanings.
+Specifically, {proglang} gives very strong composition properties: For example, nesting your program within one you do not trust cannot arbitrarily re-associate your variable occurrences with different meanings.
⬇️ Suggested change
-Specifically, {proglang} gives very strong composition properties: For example, nesting your program within one you do not trust cannot arbitrarily re-associate your variable occurrences with different meanings.
+Specifically, {proglang} gives very strong composition properties: For example, nesting your program within one you do not trust cannot arbitrarily redefine your variables with different meanings.
Thanks, would this be even better?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2579 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZBJWHROCLBGUIFFN6QJF3TSHE5TANCNFSM46P27KLA>
.
|
Contributor
|
@cPlayIt I've just committed the suggestion and added the automerge-squash label for it to merge once CI succeeds. Thanks for th e contribution - I'm sure the sdk website team will be grateful too. |
Contributor
Author
|
Thanks!
…On Mon, Jun 14, 2021, 5:02 PM Claudio Russo ***@***.***> wrote:
@cPlayIt <https://github.com/cPlayIt> I've just committed the suggestion
and added the automerge-squash label for it to merge once CI succeeds.
Thanks for th e contribution - I'm sure the sdk website team will be
grateful too.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2579 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZBJWFYDVUIX2CADQGRZY3TSZU4TANCNFSM46P27KLA>
.
|
Contributor
|
There were some merge conflicts. Too many PRs in parallel? I hope I resolved it correctly. |
nomeata
added a commit
that referenced
this pull request
Jun 15, 2021
closes #2579 Co-authored-by: cPlayIt <Playit2thelimit@gmail.com> Co-authored-by: Claudio Russo <claudio@dfinity.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.