Move more useful functions into module UnboxedSmallWord#245
Merged
Conversation
as they will be needed in `module Serialize`, and also they really belong here, as they are more closely related to our representation of small words, rather than to the code that deals with the acutal Ir AST.
ggreif
approved these changes
Mar 16, 2019
Contributor
ggreif
left a comment
ggreif
left a comment
There was a problem hiding this comment.
I agree, that these could find a cosy new home in module UnboxedSmallWord.
I am happy to bring this patch to master.
into module UnboxedSmallWord
dfinity-bot
added a commit
that referenced
this pull request
Aug 28, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@01f876ed...8f122bb4](https://github.com/dfinity-lab/common/compare/01f876edfbafbaa2b4740489a3a179ebddda062e...8f122bb4312313e8a5143d92e34f106c1c8405d9) * [`8f122bb4`](https://github.com/dfinity-lab/common/commit/8f122bb4312313e8a5143d92e34f106c1c8405d9) Revert "Revert "[INF-1384] rustc: 1.43 => 1.45, add rust-analyzer" ([dfinity-lab/common#244](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/244))" ([dfinity-lab/common#245](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/245))
mergify bot
pushed a commit
that referenced
this pull request
Aug 28, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@01f876ed...8f122bb4](https://github.com/dfinity-lab/common/compare/01f876edfbafbaa2b4740489a3a179ebddda062e...8f122bb4312313e8a5143d92e34f106c1c8405d9) * [`8f122bb4`](https://github.com/dfinity-lab/common/commit/8f122bb4312313e8a5143d92e34f106c1c8405d9) Revert "Revert "[INF-1384] rustc: 1.43 => 1.45, add rust-analyzer" ([dfinity-lab/common#244](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/244))" ([dfinity-lab/common#245](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/245)) [INF-1384]: https://dfinity.atlassian.net/browse/INF-1384
dfinity-bot
added a commit
that referenced
this pull request
Sep 2, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@e7da7f4f...ba29553a](https://github.com/dfinity-lab/common/compare/e7da7f4fa6d58e242bb7406721e9cd6c10cdb83e...ba29553a96f338b7ba8abf8c47adb7904b9f78e8) * [`f0a9530e`](https://github.com/dfinity-lab/common/commit/f0a9530eda23667d337a1ac501e0e6edb0ef20a7) INF-1483: Update niv-updater-action * [`b079b6d5`](https://github.com/dfinity-lab/common/commit/b079b6d52ecef4a7930d9dad562a07e0f840f8ea) Revert "Revert "Revert "[INF-1384] rustc: 1.43 => 1.45, add rust-analyzer" ([dfinity-lab/common#244](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/244))" ([dfinity-lab/common#245](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/245))" ([dfinity-lab/common#261](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/261)) * [`2a0a8ef1`](https://github.com/dfinity-lab/common/commit/2a0a8ef1f7591300ad6cfc807548376734660ace) INF-1486: Document how to perform a rustc upgrade * [`20f8a1f1`](https://github.com/dfinity-lab/common/commit/20f8a1f1ac78265ebaefe12d613e9931283c671f) Add ssh keys for Ryan Stout * [`5d5d566a`](https://github.com/dfinity-lab/common/commit/5d5d566a51ce9f82e9860dec6dd65aa3a75e7402) Adding account for ianblenke * [`bcc5333c`](https://github.com/dfinity-lab/common/commit/bcc5333c93718da7f34c01d8926877db082d7b3c) Formatting update * [`650d5edf`](https://github.com/dfinity-lab/common/commit/650d5edf31108143a7e9ce5cda3f1667eef65f56) Update accounts.nix * [`9be72c0b`](https://github.com/dfinity-lab/common/commit/9be72c0b2d60f35a716de0363ac7b8361e643106) nix-fmt
mergify bot
pushed a commit
that referenced
this pull request
Sep 2, 2020
## Changelog for common: Branch: master Commits: [dfinity-lab/common@e7da7f4f...ba29553a](https://github.com/dfinity-lab/common/compare/e7da7f4fa6d58e242bb7406721e9cd6c10cdb83e...ba29553a96f338b7ba8abf8c47adb7904b9f78e8) * [`f0a9530e`](https://github.com/dfinity-lab/common/commit/f0a9530eda23667d337a1ac501e0e6edb0ef20a7) INF-1483: Update niv-updater-action * [`b079b6d5`](https://github.com/dfinity-lab/common/commit/b079b6d52ecef4a7930d9dad562a07e0f840f8ea) Revert "Revert "Revert "[INF-1384] rustc: 1.43 => 1.45, add rust-analyzer" ([dfinity-lab/common#244](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/244))" ([dfinity-lab/common#245](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/245))" ([dfinity-lab/common#261](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/261)) * [`2a0a8ef1`](https://github.com/dfinity-lab/common/commit/2a0a8ef1f7591300ad6cfc807548376734660ace) INF-1486: Document how to perform a rustc upgrade * [`20f8a1f1`](https://github.com/dfinity-lab/common/commit/20f8a1f1ac78265ebaefe12d613e9931283c671f) Add ssh keys for Ryan Stout * [`5d5d566a`](https://github.com/dfinity-lab/common/commit/5d5d566a51ce9f82e9860dec6dd65aa3a75e7402) Adding account for ianblenke * [`bcc5333c`](https://github.com/dfinity-lab/common/commit/bcc5333c93718da7f34c01d8926877db082d7b3c) Formatting update * [`650d5edf`](https://github.com/dfinity-lab/common/commit/650d5edf31108143a7e9ce5cda3f1667eef65f56) Update accounts.nix * [`9be72c0b`](https://github.com/dfinity-lab/common/commit/9be72c0b2d60f35a716de0363ac7b8361e643106) nix-fmt [INF-1384]: https://dfinity.atlassian.net/browse/INF-1384
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
as they will be needed in
module Serialize, and also they reallybelong here, as they are more closely related to our representation of
small words, rather than to the code that deals with the acutal Ir AST.
@ggreif: If this is too crude I am happy for you to take over this branch, or
to do it on your own. The main goal here is to have the functions
lsb_adjustand
msb_adjustavailable in theSerializationmodule.