Skip to content

RTS: Self-contained heap representation for bignums #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 9 commits into from
Feb 3, 2021
Merged

RTS: Self-contained heap representation for bignums #2280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
eb507fe
RTS: Self-contained heap representation for bignums
nomeata Jan 29, 2021
7db2301
Inline alloc_bigint into mp_alloc
nomeata Jan 29, 2021
b710b9c
Use debug_assert_eq
nomeata Jan 29, 2021
944a772
Apply suggestions from code review
nomeata Jan 29, 2021
4894d1b
Update rts/motoko-rts/src/types.rs
nomeata Feb 3, 2021
13f4cf6
Update rts/motoko-rts/src/types.rs
nomeata Feb 3, 2021
af74025
Check overflow in mp_calloc
nomeata Feb 3, 2021
80ff5b3
Merge branch 'master' of github.com:dfinity/motoko into joachim/bignu…
nomeata Feb 3, 2021
9747961
Cargo-fmt
nomeata Feb 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions rts/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ WASM_LD ?= wasm-ld-10
#

TOMMATHFILES = \
mp_init mp_add mp_sub mp_mul mp_zero mp_cmp \
mp_init mp_zero mp_add mp_sub mp_mul mp_cmp \
mp_set_u32 mp_set_i32 mp_get_i32 mp_get_mag_u32 \
mp_set_u64 mp_set_i64 mp_get_i64 mp_get_mag_u64 \
mp_div mp_init_copy mp_neg mp_abs mp_2expt mp_expt_u32 mp_set mp_sqr \
Expand Down Expand Up @@ -166,7 +166,6 @@ $(TOMMATH_BINDINGS_RS): | _build
-o $@ \
--use-core --ctypes-prefix=libc --no-layout-tests \
--whitelist-function mp_init \
--whitelist-function mp_zero \
--whitelist-function mp_init_copy \
--whitelist-function mp_set_u32 \
--whitelist-function mp_set_i32 \
Expand All @@ -175,7 +174,6 @@ $(TOMMATH_BINDINGS_RS): | _build
--whitelist-function mp_set_i64 \
--whitelist-function mp_get_i64 \
--whitelist-function mp_count_bits \
--whitelist-function mp_get_mag_u64 \
--whitelist-function mp_cmp \
--whitelist-function mp_add \
--whitelist-function mp_sub \
Expand All @@ -191,7 +189,8 @@ $(TOMMATH_BINDINGS_RS): | _build
--blacklist-type __int32_t \
--blacklist-type __int64_t \
--blacklist-type __uint32_t \
--blacklist-type __uint64_t
--blacklist-type __uint64_t \
-- $(TOMMATH_FLAGS)

# Whitelist parameters used as libtommath.h has lots of definitions that we don't
# need. Blacklist parameters are used because bindgen still generates unused type
Expand All @@ -214,7 +213,7 @@ $(RTS_RUST_DEBUG_WASM_A): $(TOMMATH_BINDINGS_RS) | _build/wasm
#

.PHONY: test
test: $(TOMMATH_WASM_A)
test: $(TOMMATH_WASM_A) $(TOMMATH_BINDINGS_RS)
cd motoko-rts-tests && cargo build --target=wasm32-wasi
wasmtime --disable-cache --cranelift motoko-rts-tests/target/wasm32-wasi/debug/motoko-rts-tests.wasm

Expand Down
4 changes: 2 additions & 2 deletions rts/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@ libtommath and memory management
--------------------------------

We have to make libtommath’s memory management (which expects functions
`alloc`, `calloc` and `realloc`) work with the Motoko runtime. See in bigint.rs
for the technical details.
`alloc`, `calloc` and `realloc`) work with the Motoko runtime.
See `motoko-rts/src/bigint.rs` for the technical details.

Rust build
----------
Expand Down
Loading