Integer division miscompiled#213

Merged

ggreif merged 2 commits intomasterfrom

gabor/signed-div

Mar 5, 2019

Contributor

ggreif commented Mar 5, 2019 •

edited

Loading

It is compiled as unsigned division, which I have now fixed. The interpreter was correct on both test steps.

The first commit adds a failing test case.
The second adds the fix, and removes the .ok file.

I have not written an AST-xx as I regard this as a trivial fix.

ggreif added 2 commits

March 5, 2019 14:43


          failing testcase

18cfb39


          fix codegen for signed division and remove .ok

4adcab2

ggreif marked this pull request as ready for review

March 5, 2019 14:03

ggreif requested a review from nomeata

March 5, 2019 14:03

nomeata approved these changes

View reviewed changes

ggreif merged commit 7476edc into master

nomeata deleted the gabor/signed-div branch

March 5, 2019 14:18

dfinity-bot added a commit that referenced this pull request


          niv common: update 43bb392c -> 0030194f

44f988d

## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@43bb392c...0030194f](https://github.com/dfinity-lab/common/compare/43bb392c1eca82f1598efed50b3e460bdd379eb3...0030194fc2454c8a4e42bff87aa82f7f8ed96433)

* [`eb8225ea`](https://github.com/dfinity-lab/common/commit/eb8225ea65dfa4bcc688a3d58f7c9633affd9234) nix/overlays/ci.nix: increase schedulingPriority of all-systems-go
* [`dac9442c`](https://github.com/dfinity-lab/common/commit/dac9442c1110253f3386208790757ec11ff4605c) [INF-589] Incremental build support ([dfinity-lab/common⁠#213](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/213))
* [`ebaf4cf7`](https://github.com/dfinity-lab/common/commit/ebaf4cf726e75f2037570f162f79b103a3931bbd) make rustWorkspace overridable
* [`a1fb28aa`](https://github.com/dfinity-lab/common/commit/a1fb28aa2d8ddb6ac730264dc4273c4643b818f7) allow crates-io references for existing naersk builds
* [`724330e8`](https://github.com/dfinity-lab/common/commit/724330e8e6d8db0fdc6d8b835ed7b107333fed44) Update niv-updater-action to v6

mergify bot pushed a commit that referenced this pull request


          niv common: update 43bb392c -> 0030194f (#1690)

f650720

## Changelog for common:
Branch: master
Commits: [dfinity-lab/common@43bb392c...0030194f](https://github.com/dfinity-lab/common/compare/43bb392c1eca82f1598efed50b3e460bdd379eb3...0030194fc2454c8a4e42bff87aa82f7f8ed96433)

* [`eb8225ea`](https://github.com/dfinity-lab/common/commit/eb8225ea65dfa4bcc688a3d58f7c9633affd9234) nix/overlays/ci.nix: increase schedulingPriority of all-systems-go
* [`dac9442c`](https://github.com/dfinity-lab/common/commit/dac9442c1110253f3386208790757ec11ff4605c) [INF-589] Incremental build support ([dfinity-lab/common⁠#213](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity-lab/common/issues/213))
* [`ebaf4cf7`](https://github.com/dfinity-lab/common/commit/ebaf4cf726e75f2037570f162f79b103a3931bbd) make rustWorkspace overridable
* [`a1fb28aa`](https://github.com/dfinity-lab/common/commit/a1fb28aa2d8ddb6ac730264dc4273c4643b818f7) allow crates-io references for existing naersk builds
* [`724330e8`](https://github.com/dfinity-lab/common/commit/724330e8e6d8db0fdc6d8b835ed7b107333fed44) Update niv-updater-action to v6


[INF-589]: https://dfinity.atlassian.net/browse/INF-589

dfinity-bot added a commit that referenced this pull request


          niv ic-hs: update e727feca -> f718f74d

94ff12b

## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...f718f74d](dfinity/ic-hs@e727fec...f718f74)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://github.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://github.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://github.com/dfinity/ic-hs/issues/215))

dfinity-bot added a commit that referenced this pull request


          niv ic-hs: update e727feca -> f718f74d

8fff86f

## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...f718f74d](dfinity/ic-hs@e727fec...f718f74)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://github.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://github.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://github.com/dfinity/ic-hs/issues/215))

dfinity-bot added a commit that referenced this pull request


          niv ic-hs: update e727feca -> f718f74d

5dccafd

## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...f718f74d](dfinity/ic-hs@e727fec...f718f74)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://github.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://github.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://github.com/dfinity/ic-hs/issues/215))

dfinity-bot added a commit that referenced this pull request


          niv ic-hs: update e727feca -> a5f89cf5

85a4696

## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...a5f89cf5](dfinity/ic-hs@e727fec...a5f89cf)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://github.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://github.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://github.com/dfinity/ic-hs/issues/215))
* [`a5f89cf5`](dfinity/ic-hs@a5f89cf) add note that DFINITY stopped contributing ([dfinity/ic-hs⁠#216](https://github.com/dfinity/ic-hs/issues/216))

mergify bot pushed a commit that referenced this pull request


          niv ic-hs: update e727feca -> a5f89cf5 (#4134)

b120a20

## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...a5f89cf5](dfinity/ic-hs@e727fec...a5f89cf)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://github.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://github.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://github.com/dfinity/ic-hs/issues/215))
* [`a5f89cf5`](dfinity/ic-hs@a5f89cf) add note that DFINITY stopped contributing ([dfinity/ic-hs⁠#216](https://github.com/dfinity/ic-hs/issues/216))

dfinity-bot added a commit that referenced this pull request


          niv ic-hs: update e727feca -> a5f89cf5

47717c4

## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...a5f89cf5](dfinity/ic-hs@e727fec...a5f89cf)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://github.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://github.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://github.com/dfinity/ic-hs/issues/215))
* [`a5f89cf5`](dfinity/ic-hs@a5f89cf) add note that DFINITY stopped contributing ([dfinity/ic-hs⁠#216](https://github.com/dfinity/ic-hs/issues/216))

mergify bot pushed a commit that referenced this pull request


          niv ic-hs: update e727feca -> a5f89cf5 (#4672)

bbffe06

## Changelog for ic-hs:
Branch: master
Commits: [dfinity/ic-hs@e727feca...a5f89cf5](dfinity/ic-hs@e727fec...a5f89cf)

* [`99efc33f`](dfinity/ic-hs@99efc33) sync node height before making an update call in compliance tests ([dfinity/ic-hs⁠#213](https://github.com/dfinity/ic-hs/issues/213))
* [`4bdf6c35`](dfinity/ic-hs@4bdf6c3) sync node height before getStateCert ([dfinity/ic-hs⁠#214](https://github.com/dfinity/ic-hs/issues/214))
* [`f718f74d`](dfinity/ic-hs@f718f74) retry on http status of 429 ([dfinity/ic-hs⁠#215](https://github.com/dfinity/ic-hs/issues/215))
* [`a5f89cf5`](dfinity/ic-hs@a5f89cf) add note that DFINITY stopped contributing ([dfinity/ic-hs⁠#216](https://github.com/dfinity/ic-hs/issues/216))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet