Skip to content

Fix typos #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggreif merged 2 commits into from
Mar 3, 2019
Merged

Fix typos #209

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d2dc2e
fixes typo
ggreif Feb 17, 2019
1705f4f
Update definedness.ml
ggreif Mar 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion default.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ let real-dvm =
then
if !builtins.pathExists ./nix/dev/default.nix
then
throw "\"test-dvm = true\" requires a checkout of dev in ./nix.\nSee Jenkinsfile for the reqiure revision. "
throw "\"test-dvm = true\" requires a checkout of dev in ./nix.\nSee Jenkinsfile for the required revision. "
else
# Pass devel = true until the dev test suite runs on MacOS again
((import ./nix/dev) { devel = true; }).dvm
Expand Down
4 changes: 2 additions & 2 deletions src/definedness.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
This module implements a check that rules out use-before define.
It is a compositional algorithm that returns, for each subexpression,
* Which variables are used eagerly and
* which are delayd
* which are delayed
these sets are disjoint and their union makes up the set of free variables, so
the structure of this module is very similar to that of freevars.ml.

Expand Down Expand Up @@ -187,7 +187,7 @@ and decs msgs decs : f =
let e = set_unions (List.map (fun (_,_,eager,_) ->
NameRel.range (NameRel.restricted_rtcl eager r)
) decs') in
(* Every thing else is lazy *)
(* Everything else is lazy *)
let d = S.diff (set_unions (List.map (fun (_,_,_,delayed) -> delayed) decs')) e in
(* And remove whats defined here *)
M.disjoint_union (map_of_set Eager e) (map_of_set Delayed d) |>
Expand Down