Closed
Conversation
this turned out to be a bigger change, uncovering a few dirty spots in
`Check_ir` and other places.
This codifies also that, in the IR:
* All `BlockE` expressions end with an `ExprE`
* Only `ExpD` declarations return their type (this is differs from
Source)
Contributor
Author
|
Hmpf, this branch name confuses Jenkins. Let’s try again. |
dfinity-bot
added a commit
that referenced
this pull request
Mar 5, 2021
## Changelog for candid: Branch: master Commits: [dfinity/candid@322ea4a2...66bdb7d0](dfinity/candid@322ea4a...66bdb7d) * [`5ca4e08b`](dfinity/candid@5ca4e08) optimize performance for blob ([dfinity/candid#194](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/194)) * [`307a0c02`](dfinity/candid@307a0c0) expose pp_function * [`66bdb7d0`](dfinity/candid@66bdb7d) release ([dfinity/candid#195](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/195))
mergify bot
pushed a commit
that referenced
this pull request
Mar 5, 2021
## Changelog for candid: Branch: master Commits: [dfinity/candid@322ea4a2...66bdb7d0](dfinity/candid@322ea4a...66bdb7d) * [`5ca4e08b`](dfinity/candid@5ca4e08) optimize performance for blob ([dfinity/candid#194](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/194)) * [`307a0c02`](dfinity/candid@307a0c0) expose pp_function * [`66bdb7d0`](dfinity/candid@66bdb7d) release ([dfinity/candid#195](http://r.duckduckgo.com/l/?uddg=https://github.com/dfinity/candid/issues/195))
dfinity-bot
added a commit
that referenced
this pull request
Jun 23, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@52369fa1...f092a2d5](dfinity/ic-hs@52369fa...f092a2d) * [`12590345`](dfinity/ic-hs@1259034) bump cachix/install-nix-action ([dfinity/ic-hs#201](https://github.com/dfinity/ic-hs/issues/201)) * [`2ef5690c`](dfinity/ic-hs@2ef5690) Bump openssl from 0.10.48 to 0.10.55 in /httpbin-rs ([dfinity/ic-hs#202](https://github.com/dfinity/ic-hs/issues/202)) * [`46af8266`](dfinity/ic-hs@46af826) sync httpbin implementation with ic repo ([dfinity/ic-hs#193](https://github.com/dfinity/ic-hs/issues/193)) * [`1fd276eb`](dfinity/ic-hs@1fd276e) implement Call context removal transition ([dfinity/ic-hs#191](https://github.com/dfinity/ic-hs/issues/191)) * [`11c00d2a`](dfinity/ic-hs@11c00d2) catch HTTP exception from HTTPS outcalls ([dfinity/ic-hs#195](https://github.com/dfinity/ic-hs/issues/195)) * [`9eb5bf48`](dfinity/ic-hs@9eb5bf4) deleted call contexts prevent canister from stopping (again) ([dfinity/ic-hs#190](https://github.com/dfinity/ic-hs/issues/190)) * [`f092a2d5`](dfinity/ic-hs@f092a2d) implement and test canister history ([dfinity/ic-hs#198](https://github.com/dfinity/ic-hs/issues/198))
mergify bot
pushed a commit
that referenced
this pull request
Jun 23, 2023
## Changelog for ic-hs: Branch: master Commits: [dfinity/ic-hs@52369fa1...f092a2d5](dfinity/ic-hs@52369fa...f092a2d) * [`12590345`](dfinity/ic-hs@1259034) bump cachix/install-nix-action ([dfinity/ic-hs#201](https://github.com/dfinity/ic-hs/issues/201)) * [`2ef5690c`](dfinity/ic-hs@2ef5690) Bump openssl from 0.10.48 to 0.10.55 in /httpbin-rs ([dfinity/ic-hs#202](https://github.com/dfinity/ic-hs/issues/202)) * [`46af8266`](dfinity/ic-hs@46af826) sync httpbin implementation with ic repo ([dfinity/ic-hs#193](https://github.com/dfinity/ic-hs/issues/193)) * [`1fd276eb`](dfinity/ic-hs@1fd276e) implement Call context removal transition ([dfinity/ic-hs#191](https://github.com/dfinity/ic-hs/issues/191)) * [`11c00d2a`](dfinity/ic-hs@11c00d2) catch HTTP exception from HTTPS outcalls ([dfinity/ic-hs#195](https://github.com/dfinity/ic-hs/issues/195)) * [`9eb5bf48`](dfinity/ic-hs@9eb5bf4) deleted call contexts prevent canister from stopping (again) ([dfinity/ic-hs#190](https://github.com/dfinity/ic-hs/issues/190)) * [`f092a2d5`](dfinity/ic-hs@f092a2d) implement and test canister history ([dfinity/ic-hs#198](https://github.com/dfinity/ic-hs/issues/198))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this turned out to be a bigger change, uncovering a few dirty spots in
Check_irand other places.This codifies also that, in the IR:
BlockEexpressions end with anExprEExpDdeclarations return their type (this is differs fromSource)