-
Notifications
You must be signed in to change notification settings - Fork 121
Tailcall ir #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Tailcall ir #133
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
48ce023
starting on IR-based refactoring of existing syntaxops module
matthewhammer aa4e910
starting on IR-based refactoring of existing syntaxops module
matthewhammer 4936642
broken state: marked all places that need edits
matthewhammer 503efae
still broken, but fewer broken parts, hopefully
matthewhammer 4b25aee
fixed remaining questions with Claudio's help
matthewhammer 061d24b
minor; avoid warning
matthewhammer 0b6a586
revert change to .gitignore
matthewhammer 7d7ed49
Revert "minor; avoid warning"
matthewhammer d924f11
Merge branch 'master' of github.com:dfinity-lab/actorscript into synt…
matthewhammer d567333
fix 'unused module' warning
matthewhammer 40a5606
refactor tailcall module to use Ir in place of Syntax
matthewhammer 7aa8825
minor: fix confusing typo in note
matthewhammer 26072a4
use Claudio's review: hints and feedback
matthewhammer c7bf4e4
use Claudio's review: hints and feedback, continued.
matthewhammer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you tried replacing the existing tco with the new one? You'd have to move desugar up just before tco and then call the new version of tco.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not yet. How would I notice problems? Some regression tests would/might fail?