Closes caelum/vraptor#581. Only instantiate objects with same type #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Affects vraptor3. If this pull request will accepted, we need to replicate the changes. |
| List<Message> errors = new ArrayList<Message>(); | ||
| Object[] out = provider.getParametersFor(method, errors); | ||
|
|
||
| assertThat(out[0], not(is(result))); |
There was a problem hiding this comment.
Yeah, because Result is a vraptor object that we can't get. We want to get only parameters, not vraptor objects. This is the propose of the issue.
There was a problem hiding this comment.
is(not(result)) reads better than not(is(result)) ;) 🍂
|
🚌 |
| OtherResource.class.getDeclaredMethod("logic", String.class)); | ||
|
|
||
| List<Message> errors = new ArrayList<Message>(); | ||
| Object[] out = provider.getParametersFor(method, errors); |
There was a problem hiding this comment.
I've changed the test because I think that we need to check if IOGI got the right parameter too. @lucascs right?
garcia-jj
added a commit
that referenced
this pull request
Feb 5, 2014
Closes caelum/vraptor#581. Only instantiate objects with same type
|
@lucascs Thank you for review my code. |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes caelum/vraptor#581.