Health check #617
Merged
Health check #617
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java
Show resolved
Hide resolved
src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java
Outdated
Show resolved
Hide resolved
src/main/java/com/uber/cadence/serviceclient/WorkflowServiceTChannel.java
Outdated
Show resolved
Hide resolved
longquanzheng
approved these changes
Jun 17, 2021
There was a problem hiding this comment.
LGTM(except that the name of isHealthy may be misleading for caller.
@mkolodezny @meiliang86 do you also want to take a look?
This PR should be safe to land -- it introduces a new optional API in worker/workerFactory and doesn't change any existing behavior.
@AngerM-DD thank you for the contribution.
longquanzheng
approved these changes
Jun 25, 2021
demirkayaender
added a commit
to demirkayaender/cadence-java-client
that referenced
this pull request
Jul 13, 2021
…-workflow#617)" This reverts commit 63a34bc.
AngerM-DD
added a commit
to AngerM-DD/cadence-java-client
that referenced
this pull request
Oct 26, 2021
new files undo defaultContextProp changes remove bad calls to method no longer in this pr remove health check from this PR remove default adding of otel Add Health check API to worker and service interface (cadence-workflow#617)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a health check to the cadence-java sdk. It is useful is k8s environments where you pass in a DNS name as opposed to an IP address. This change allows you to detect if the client can no longer connect to the cadence servers and attempt to re-resolve the dns name if one was used.