Remove warning message that regarding unknown event type #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timl3136
requested review from
Groxx,
shijiesheng,
agautam478,
jakobht,
3vilhamster,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
taylanisikdemir
approved these changes
Nov 28, 2023
internal/internal_utils.go
Outdated
| default: | ||
| logger.Warn("unknown event type", zap.String("Event Type", event.GetEventType().String())) | ||
| // Do not fail to be forward compatible with new events | ||
| default: // Do not fail to be forward compatible with new events |
There was a problem hiding this comment.
you can remove default case since it's no-op
3vilhamster
reviewed
Dec 4, 2023
| @@ -468,10 +468,6 @@ func estimateHistorySize(logger *zap.Logger, event *s.HistoryEvent) int { | |||
| sum += len(event.SignalExternalWorkflowExecutionInitiatedEventAttributes.Control) | |||
| sum += len(event.SignalExternalWorkflowExecutionInitiatedEventAttributes.Input) | |||
| } | |||
|
|
|||
| default: | |||
| logger.Warn("unknown event type", zap.String("Event Type", event.GetEventType().String())) | |||
There was a problem hiding this comment.
Maybe it could be useful to have this log with Debug level?
There was a problem hiding this comment.
Good idea, let me change that to debug level logs
timl3136
force-pushed
the
history-size-patch
branch
from
b69eb5b to
2ac0768
Compare
timl3136
added a commit
that referenced
this pull request
Dec 5, 2023
…on (#1300) What changed? Change warning message for unknown event type to debug level Why? It's creating too much warning log that overwhelm system How did you test it? Unit test Potential risks Only remove logger so no danger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Remove warning message for unknown event type
Why?
It's creating too much warning log that overwhelm system
How did you test it?
Unit test
Potential risks
Only remove logger so no danger