Fixed error log #1284
Merged
Fixed error log #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timl3136
pushed a commit
that referenced
this pull request
Nov 4, 2023
What changed? We currently log the wrong error which is always nil, so fixed to log the correct error Why? Because we log the wrong error How did you test it? N/A Potential risks Very low, just changing a log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
We currently log the wrong error which is always nil, so fixed to log the correct error
Why?
Because we log the wrong error
How did you test it?
N/A
Potential risks
Very low, just changing a log