Document ErrResultPending's behavioral gap explicitly #1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolving this "two kinds of finished-timeout / heartbeat-timeout" issue with ErrResultPending will need some new semantics on the server side... but at least there's a workaround until then. The general concept of a "pending activity" does seem worth supporting, particularly because it can respond with an "already completed" error when a second "complete" request is received. It just has unfortunate quirks at the moment.
neil-xie
approved these changes
Mar 16, 2023
Groxx
added a commit
to Groxx/cadence-java-client
that referenced
this pull request
Mar 16, 2023
Java counterpart to cadence-workflow/cadence-go-client#1229 Resolving this "two kinds of finished-timeouts / heartbeat-timeouts, but only one config" issue with Activity.doNotCompleteOnReturn will need some new semantics on the server side... but at least there's a workaround until then. The general concept of a "pending activity" does seem worth supporting, particularly because it can respond with an "already completed" error when a second "complete" request is received. It just has unfortunate quirks at the moment.
mindaugasbarcauskas
pushed a commit
to cadence-workflow/cadence-java-client
that referenced
this pull request
Mar 28, 2023
#776) * Fix gradle for M1 OSX machines * Document doNotCompleteOnReturn's behavioral gap explicitly Java counterpart to cadence-workflow/cadence-go-client#1229 Resolving this "two kinds of finished-timeouts / heartbeat-timeouts, but only one config" issue with Activity.doNotCompleteOnReturn will need some new semantics on the server side... but at least there's a workaround until then. The general concept of a "pending activity" does seem worth supporting, particularly because it can respond with an "already completed" error when a second "complete" request is received. It just has unfortunate quirks at the moment. * sometimes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolving this "two kinds of finished-timeouts / heartbeat-timeouts, but only one config" issue with ErrResultPending will need some new semantics on the server side... but at least there's a workaround until then.
The general concept of a "pending activity" does seem worth supporting, particularly because it can respond with an "already completed" error when a second "complete" request is received. It just has unfortunate quirks at the moment.