Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more detail to how workflow.Now behaves #1228

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

Groxx
Copy link
Member

@Groxx Groxx commented Mar 14, 2023

Docs are currently a bit vague on what time exactly it represents, which brings up questions like "is this the same as the cron schedule start time" or "what time does it represent if my workers are down for an hour".

So this description was gathered experimentally.
It may be a good idea to track exactly what updates it and when, but I suspect that the "recorded event" is a complete description. Or it probably should be.

Docs are currently a bit vague on what time exactly it represents, which brings up questions like "is this the same as the cron schedule start time" or "what time does it represent if my workers are down for an hour".

So this description was gathered experimentally.
It may be a good idea to track exactly what updates it and when, but I suspect that the "recorded event" is a complete description.  Or it probably should be.
@Groxx Groxx force-pushed the workflow-now-clearer branch from 4cefc12 to eddfb89 Compare March 14, 2023 23:55
Copy link
Member

@davidporter-id-au davidporter-id-au left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<3

@Groxx Groxx merged commit 8fd9d91 into cadence-workflow:master Mar 15, 2023
@Groxx Groxx deleted the workflow-now-clearer branch March 15, 2023 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants