Adding ability to provide cancellation reason to cancelWorkflow API #1213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mindaugasbarcauskas
changed the title
Groxx
approved these changes
Jan 31, 2023
Groxx
added a commit
to Groxx/cadence-client
that referenced
this pull request
Feb 4, 2023
…ended Missed this during review of cadence-workflow#1213, sorry! I'm not entirely sure how to catch things like this in tests, without a separate module...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Adding ability to provide options to cancel workflow API.
Why?
In order to allow populating cancel reason.
How did you test it?
Added unit tests.
Potential risks