Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix runDev when running on windows #33

Merged
merged 1 commit into from
Aug 26, 2020
Merged

Fix runDev when running on windows #33

merged 1 commit into from
Aug 26, 2020

Conversation

jaysonsantos
Copy link
Contributor

Extract default output file to a function and reuse it in both runBuild and runDev

@jaysonsantos
Fix runDev when running on windows
85014d4 
Extract default output file to a function and reuse it in both runBuild and runDev
mholt
mholt approved these changes Aug 26, 2020
View reviewed changes
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks. This is probably a good thing to do (though, I don't know if it's strictly necessary?).

@mholt mholt merged commit 13c49c3 into caddyserver:master Aug 26, 2020
@jaysonsantos jaysonsantos deleted the run-dev-windows-output-file branch August 26, 2020 18:37
@jaysonsantos
Copy link
Contributor Author

@mholt when executing on my windows box it failed because of the missing extension

@ydylla ydylla mentioned this pull request Sep 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mholt mholt mholt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jaysonsantos @mholt