memory storage

[elee1766]

renames existing memoryStorage -> testingMemoryStorage, as it is a special storage only used for testing

creates memoryStorage, which can only be created through calling NewMemoryStorage

memory storage is thread safe, supports lock keyed by file

[mholt]

Thanks! Is there a reason we need two? Like, why not just use the new memoryStorage for testing too?

[elee1766]

Thanks! Is there a reason we need two? Like, why not just use the new memoryStorage for testing too?

i'm not sure.

// testingMemoryStorage is an in-memory storage implementation with known contents and fixed iteration order for List.

i assume those things matter for testing, and the map based in-memory store can't do things, so my guess is we can't.

[mholt]

Hmm. I still wonder if we can just use the one for both. (In other words, keep the new memoryStorage type, and just use it instead of the new testingMemoryStorage type.) I haven't had a chance to explore this but could we possibly try it if anyone has a chance?

[elee1766]

i can try to look for some time to investigate. i am usually afraid of changing existing tests.