Skip to content

Conversation

@WeidiDeng
Copy link
Member

Fix 7250.

Assistance Disclosure

No AI was used.

@francislavoie
Copy link
Member

francislavoie commented Sep 11, 2025

So I guess #7042 wasn't enough?

Windows test failure is:

=== RUN   TestAdminHandlerBuiltinRouteErrors
    admin_test.go:282: setting up admin server: listen tcp 127.0.0.1:2019: bind: Only one usage of each socket address (protocol/network address/port) is normally permitted.
--- FAIL: TestAdminHandlerBuiltinRouteErrors (0.00s)

Not sure what the deal is, this seems new, it used to be fine?

@mholt
Copy link
Member

mholt commented Sep 11, 2025

@francislavoie I think the tests are just flaky. I see equivalent errors on my local Linux box quite often. I re-ran the tests and they pass now.

Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Weidi!

@mholt mholt merged commit b462615 into master Sep 11, 2025
26 checks passed
@mholt mholt deleted the fix-precompressed-206 branch September 11, 2025 04:48
@francislavoie francislavoie added this to the v2.10.3 milestone Sep 14, 2025
@francislavoie francislavoie modified the milestones: v2.10.3, v2.11.0 Oct 16, 2025
@github-actions github-actions bot mentioned this pull request Dec 3, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Weird 206 status codes for precompressed brotli files

4 participants