Skip to content

Conversation

@aro-lew
Copy link
Contributor

@aro-lew aro-lew commented Aug 26, 2025

This change adds application/graphql-response+json* to the list of default encoded header Content-Types. According to the GraphQL specification, GraphQL responses should be served with this content type. Adding it to the default encoded headers ensures proper handling and encoding of GraphQL responses.

Note:
If this is merged, the website should be updated accordingly to reflect the new header type.

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2025

CLA assistant check
All committers have signed the CLA.

@mholt
Copy link
Member

mholt commented Aug 26, 2025

Thanks for the PR. I don't use GraphQL so I'll trust you've tested it. :)

This PR is missing our new assistance disclosure btw -- when I go to make a PR, it's working (it shows up for me as a PR template). Did you not see the template when you created the PR?

@aro-lew
Copy link
Contributor Author

aro-lew commented Aug 27, 2025

Yes, the template did show up. I got a bit confused and deleted it — sorry about that! Here’s the missing part:

Assistance Disclosure

I consulted ChatGPT for a solution, but I coded it myself.

@mholt
Copy link
Member

mholt commented Aug 27, 2025

Thanks, just wondering since it's still new. (Anything we could do to make it less confusing?)

@mholt mholt merged commit 806fef8 into caddyserver:master Aug 27, 2025
23 checks passed
@aro-lew aro-lew deleted the add-encode-graphql-response branch August 28, 2025 08:05
@github-actions github-actions bot mentioned this pull request Dec 3, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants